Failed tests:
testValidateEPUBvalid20(com.adobe.epubcheck.api.Epub20CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBvalidIssue169(com.adobe.epubcheck.api.Epub20CheckTest):
[creation date] 1305812502000 not found
testValidateEPUBPvalid30(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBTestSvg(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBMp3(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBMp3WithFallback(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBFontFallbackChain(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUBvalid30(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUB30ValidExtension1(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1314890214000 not found
testValidateEPUB30CSSProfile(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1323797838000 not found
testValidateEPUB30Issue158(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1330492368000 not found
testValidateEPUB30specValid(com.adobe.epubcheck.api.Epub30CheckTest):
[creation date] 1329214800000 not found
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39.948s
[INFO] Finished at: Thu Oct 25 15:00:17 BST 2012
[INFO] Final Memory: 18M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.10:test
(default-test) on project epubcheck: There are test failures.
[ERROR]
[ERROR] Please refer to
/Users/lotia/anobiidev/epubcheck/branches/epub3-maven/com.adobe.epubcheck/target/surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Romain Deltour
unread,
Oct 25, 2012, 7:57:51 PM10/25/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Can you please send more details about your environment (available by running "mvn -v") ?
I've just tested the build successfully on:
- Mac OS X 10.8.2 / Java 1.7.0_07 / Maven 3.0.4
- Ubuntu 12.04 / Java 1.6.0_24 / Maven 3.0.4
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Dear Romain,
Thanks for the speedy response. I'm sorry it's taken me so long to
reply with the requested output which is provided below.
$ mvn -v
Apache Maven 3.0.4 (r1232337; 2012-01-17 08:44:56+0000)
Maven home: /usr/share/maven
Java version: 1.6.0_37, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.6.8", arch: "x86_64", family: "mac"
Best,
Ali
Romain Deltour
unread,
Oct 27, 2012, 3:30:51 PM10/27/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
I'm confused: I just ran it successfully on the following environment, which is almost the same as yours (except for the OS X version, which shouldn't impact the build or tests):
Java version: 1.6.0_37, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.8.2", arch: "x86_64", family: "mac"
Is your subversion working copy up-to-date and with no local modifications ?
If yes, can you maybe try to (temporarily) rename your ~/.m2 Maven local repository to start from a clean Maven environment ?
Romain.
Ali Asad Lotia
unread,
Oct 29, 2012, 11:54:14 AM10/29/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Hi Romain,
I have now tried it on a CentOS 6.3 machine on which I have installed
maven 3.0.4 and I get the same output. It is downloading all the
required dependencies since it is creating a fresh local maven repo. I
have also tested with renaming my existing maven repo on my MacOS
10.6.8 machine and it fails the same 10 unit tests as are failed
below.
--
Ali
[INFO] Total time: 1:19.385s
[INFO] Finished at: Mon Oct 29 15:25:50 GMT 2012
[INFO] Final Memory: 24M/160M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.10:test
(default-test) on project epubcheck: There are test failures.
[ERROR]
[ERROR] Please refer to
for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[lotia@dbhack com.adobe.epubcheck]$ mvn -e
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Total time: 0.151s
[INFO] Finished at: Mon Oct 29 15:26:00 GMT 2012
[INFO] Final Memory: 2M/114M
[INFO] ------------------------------------------------------------------------
[ERROR] No goals have been specified for this build. You must specify
a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal>
or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>.
Available lifecycle phases are: validate, initialize,
generate-sources, process-sources, generate-resources,
process-resources, compile, process-classes, generate-test-sources,
process-test-sources, generate-test-resources, process-test-resources,
test-compile, process-test-classes, test, prepare-package, package,
pre-integration-test, integration-test, post-integration-test, verify,
install, deploy, pre-clean, clean, post-clean, pre-site, site,
post-site, site-deploy. -> [Help 1]
org.apache.maven.lifecycle.NoGoalSpecifiedException: No goals have
been specified for this build. You must specify a valid lifecycle
phase or a goal in the format <plugin-prefix>:<goal> or
<plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>.
Available lifecycle phases are: validate, initialize,
generate-sources, process-sources, generate-resources,
process-resources, compile, process-classes, generate-test-sources,
process-test-sources, generate-test-resources, process-test-resources,
test-compile, process-test-classes, test, prepare-package, package,
pre-integration-test, integration-test, post-integration-test, verify,
install, deploy, pre-clean, clean, post-clean, pre-site, site,
post-site, site-deploy.
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:104)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
Maven home: /opt/maven/apache-maven-3.0.4
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "2.6.32-279.5.2.el6.x86_64", arch: "amd64",
family: "unix"
Thomas
unread,
Nov 2, 2012, 4:25:27 PM11/2/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Hi Ali,
I just commited some corrections in r370. While doing my tests, I run into the same issue than you and I appears that some file texts used during tested where encoded in UTF-8 with BOM which make the test to fail.
Could you please retry your build and let me know?
Thanks in advance  Thomas
Romain Deltour
unread,
Nov 2, 2012, 4:44:44 PM11/2/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Thomas,
I believe Ali's issue below was not an encoding issue. The problem is that the creation date field in the text file reports is time-zone sensitive. The fix would be to output a creation date relative to UTC when writing to the test reports or to simply get rid of the text file reports altogether, which do not really belong to the unit tests IMHO.
Anyway, wrt encoding issues, I did face an issue some time ago due to a text report file that was encoded in latin1 but opened as utf8, but I transcoded the file since then.
The tests run fine on revision 371 (if you're in the CET zone).
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Romain,
this is quite peculiar. Indeed, the [creation date] comes from the
time of the container.xml file in the zip container. From
http://docs.oracle.com/javase/1.4.2/docs/api/java/util/zip/ZipEntry.html#setTime%28long%29,
the time is supposed to be "the entry modification time in number of
milliseconds since the epoch". So for me this information should not
depend on the local timezone !!! I will look into that to understand
why this value varies.
By the way, the text files in the test environment are not test
reports; they are just reference information (some interesting part of
the report) to be matched with the actual generated reports as part of
the unit tests.
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
> this is quite peculiar. Indeed, the [creation date] comes from the
> time of the container.xml file in the zip container. From
> http://docs.oracle.com/javase/1.4.2/docs/api/java/util/zip/ZipEntry.html#setTime%28long%29,
> the time is supposed to be "the entry modification time in number of
> milliseconds since the epoch". So for me this information should not
> depend on the local timezone !!! I will look into that to understand
> why this value varies.
Well, the ZIP contains no info on the time zone where the ZIP entry was created, so the API returns the entry modification time by assuming that the entry was created in the same time zone as the current one.
In other words, if you call ZipEntry#getTime on two different time zones, you will get two different values.
> By the way, the text files in the test environment are not test
> reports; they are just reference information (some interesting part of
> the report) to be matched with the actual generated reports as part of
> the unit tests.
I know, but I believe that it does not make a lot of sense to test that the report matches for each single test method. The "unit" tests are quite focused ; testing the entire report info makes it a tad more dependent on non-related parts of epubcheck. Additionally, it's a bit more difficult to maintain since every time we will like to update the text report format we will need to re-generate the reports for all the test samples.
Romain.
>
> Best
> Thomas
>
> 2012/11/2, Romain Deltour <rdel...@gmail.com>:
>> Thomas,
>>
>> I believe Ali's issue below was not an encoding issue. The problem is that
>> the creation date field in the text file reports is time-zone sensitive. The
>> fix would be to output a creation date relative to UTC when writing to the
>> test reports or to simply get rid of the text file reports altogether, which
>> do not really belong to the unit tests IMHO.
>>
>> Anyway, wrt encoding issues, I did face an issue some time ago due to a text
>> report file that was encoded in latin1 but opened as utf8, but I transcoded
>> the file since then.
>>
>> The tests run fine on revision 371 (if you're in the CET zone).
>>
>> Romain.
>>
>> On 2 nov. 2012, at 21:25, Thomas <tled...@gmail.com> wrote:
>>
>>> Hi Ali,
>>>
>>> I just commited some corrections in r370.
>>> While doing my tests, I run into the same issue than you and I appears
>>> that some file texts used during tested where encoded in UTF-8 with BOM
>>> which make the test to fail.
>>>
>>> Could you please retry your build and let me know?
>>>
>>> Thanks in advance
>>> Thomas
>>>
>>>
>
Thomas Ledoux
unread,
Nov 2, 2012, 6:32:24 PM11/2/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Hi Romain,
indeed you were correct. I now calculate an UTC creation date which is
independent of the local timezone. The tests do now work even when I
pretend to be in India :-)
For the test part, the information in the text files is just an
extract of the validation report (the one we want to test). So the
values in the files need to be changed only when the information is
wrong (like for the creation date) and they have been useful to find
my error...
Ali Asad Lotia
unread,
Nov 10, 2012, 10:27:58 AM11/10/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to epub...@googlegroups.com
Hi Thomas and other list members,
I'm sorry for the slow response time. I've been travelling.