Packaging maven epub3-maven branch - epubcheck

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Packaging maven epub3-maven branch
Received-SPF: pass (google.com: domain of rdelt...@gmail.com designates 74.125.82.177 as permitted sender) client-ip=74.125.82.177;
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: Packaging maven epub3-maven branch
From: Romain Deltour <rdelt...@gmail.com>
In-Reply-To: <CAAEmz6PEfdPwpmP4Kk4pBiwe0_C_6=0jCySW0xQXeEXXDT7...@mail.gmail.com>
Date: Fri, 2 Nov 2012 22:34:12 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <A1B02409-DA5D-44BC-9EFB-77FF5C64F...@gmail.com>
References: <CAGdiRnfYAp0U0V5YFbH69iyaDfDqZEqr8xVqUhuW2XHT=gC...@mail.gmail.com> <DF63B696-C4B7-4C2B-BC12-8A873D6BC...@gmail.com> <CAGdiRnc2iaHEPO3NxCFcoxmiGD04gLys_x7K9OgBj1W12Fv...@mail.gmail.com> <66C6734A-5626-4A09-825E-228FE82C7...@gmail.com> <CAGdiRnfbjSG1s73TPPkPamP0yqW7Lk5qABhRD=un7WaEW41...@mail.gmail.com> <d6d1df33-a1dc-4e8e-83a5-0a1b2bbed263@googlegroups.com> <7280BE85-1C35-4795-BD67-64BF20632...@gmail.com> <CAAEmz6PEfdPwpmP4Kk4pBiwe0_C_6=0jCySW0xQXeEXXDT7...@mail.gmail.com>
To: epubcheck@googlegroups.com

> this is quite peculiar. Indeed, the [creation date] comes from the
> time of the container.xml file in the zip container. From
> =
http://docs.oracle.com/javase/1.4.2/docs/api/java/util/zip/ZipEntry.html#s=
etTime%28long%29,
> the time is supposed to be "the entry modification time in number of
> milliseconds since the epoch". So for me this information should not
> depend on the local timezone !!! I will look into that to understand
> why this value varies.

Well, the ZIP contains no info on the time zone where the ZIP entry was =
created, so the API returns the entry modification time by assuming that =
the entry was created in the same time zone as the current one.
In other words, if you call ZipEntry#getTime on two different time =
zones, you will get two different values.

> By the way, the text files in the test environment are not test
> reports; they are just reference information (some interesting part of
> the report) to be matched with the actual generated reports as part of
> the unit tests.

I know, but I believe that it does not make a lot of sense to test that =
the report matches for each single test method. The "unit" tests are =
quite focused ; testing the entire report info makes it a tad more =
dependent on non-related parts of epubcheck. Additionally, it's a bit =
more difficult to maintain since every time we will like to update the =
text report format we will need to re-generate the reports for all the =
test samples.

Romain.

>=20
> Best
>  Thomas
>=20
> 2012/11/2, Romain Deltour <rdelt...@gmail.com>:
>> Thomas,
>>=20
>> I believe Ali's issue below was not an encoding issue. The problem is =
that
>> the creation date field in the text file reports is time-zone =
sensitive. The
>> fix would be to output a creation date relative to UTC when writing =
to the
>> test reports or to simply get rid of the text file reports =
altogether, which
>> do not really belong to the unit tests IMHO.
>>=20
>> Anyway, wrt encoding issues, I did face an issue some time ago due to =
a text
>> report file that was encoded in latin1 but opened as utf8, but I =
transcoded
>> the file since then.
>>=20
>> The tests run fine on revision 371 (if you're in the CET zone).
>>=20
>> Romain.
>>=20
>> On 2 nov. 2012, at 21:25, Thomas <tledou...@gmail.com> wrote:
>>=20
>>> Hi Ali,
>>>=20
>>> I just commited some corrections in r370.
>>> While doing my tests, I run into the same issue than you and I =
appears
>>> that some file texts used during tested where encoded in UTF-8 with =
BOM
>>> which make the test to fail.
>>>=20
>>> Could you please retry your build and let me know?
>>>=20
>>> Thanks in advance
>>>  Thomas
>>>=20
>>>=20
>=20
> --=20
> You received this message because you are subscribed to the Google =
Groups "epubcheck" group.
> To post to this group, send email to epubcheck@googlegroups.com.
> To unsubscribe from this group, send email to =
epubcheck+unsubscribe@googlegroups.com.
> For more options, visit this group at =
http://groups.google.com/group/epubcheck?hl=3Den.
>=20
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
