PR #46: Subgrid size change and FOF bugfix

3 views
Skip to first unread message

John Wise

unread,
May 10, 2012, 10:48:18 AM5/10/12
to enzo...@googlegroups.com
Hi everyone,

Here's a pull request that I just submitted that contains some minor
changes, but it will affect all simulations because it adjusts the
limits of the maximum subgrid size.

John

-------- Original Message --------
Subject: [enzo/enzo-dev] Subgrid size change and FOF bugfix (pull
request #46)
Date: Thu, 10 May 2012 14:42:11 -0000
From: John Wise <pullreques...@bitbucket.org>
To: co...@enzo-project.org

A new pull request has been opened by John Wise.

jwise77/clean-copy has changes to be pulled into enzo/enzo-dev.

https://bitbucket.org/enzo/enzo-dev/pull-request/46/subgrid-size-change-and-fof-bugfix

Title: Subgrid size change and FOF bugfix

There are two changes in this PR.

1. I've adjusted the MINIMUM_SIZE and MINIMUM_EDGE to 2000 and 4, so
grids aren't too small when determining the maximum subgrid size. Also
this avoid many small grids when a level is suddenly flagged for
refinement, like during initialization or must-refine regions.

2. Thanks to Manodeep Sinha to finding a couple of bugs in the FOF halo
finder. This affected the r200 calculation in halos that straddled
periodic boundaries.

Changes to be pulled:

3e0835ded7a0 by John Wise: "Changing minimum_size and edge to 2000 and
4, respectively. Bumping
grids_per_p…"
a0426e3de754 by John Wise: "Merging."
4519ac28c685 by John Wise: "When calculating r200 in the FOF halo
finder, the particle separation
must use p…"
0647511daca8 by John Wise: "Merging"


--
This is an issue notification from bitbucket.org.
You are receiving this either because you are the participating
in a pull request, or you are following it.

Reply all
Reply to author
Forward
0 new messages