Obsolete macros

[Sebastien Vauban]

Hello Thierry,

When using an Emacs snapshot from a couple of days ago (Emacs 24.2.50.1 of
2012-10-22), I get the following warnings in the Messages buffer:

`labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
`flet' is an obsolete macro (as of 24.3); use either `cl-flet' or `cl-letf'.

Best regards,
Seb

--
Sebastien Vauban

[Thierry Volpiatto]

Hi Sebastien,

"Sebastien Vauban" <wxhgmq...@spammotel.com> writes:

> Hello Thierry,
>
> When using an Emacs snapshot from a couple of days ago (Emacs 24.2.50.1 of
> 2012-10-22), I get the following warnings in the Messages buffer:
>
> `labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
> `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or `cl-letf'.

Should be fixed now: (bug#12486).

--8<---------------cut here---------------start------------->8---
* lisp/emacs-lisp/macroexp.el (macroexp--expand-all): Obey byte-compile-warning-enabled-p.
author Stefan Monnier <mon...@iro.umontreal.ca>
date Fri, 26 Oct 2012 11:59:40 -0400 (2 hours ago)
parents 48ef68353388
children bf6ab6cef435
files lisp/ChangeLog lisp/emacs-lisp/macroexp.el
--8<---------------cut here---------------end--------------->8---

Thanks.

--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

[Sebastien Vauban]

Hi Thierry,

Thierry Volpiatto wrote:

> "Sebastien Vauban" <wxhgmq...@spammotel.com> writes:
>>
>> When using an Emacs snapshot from a couple of days ago (Emacs 24.2.50.1 of
>> 2012-10-22), I get the following warnings in the Messages buffer:
>>
>> `labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
>> `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or
>> `cl-letf'.
>
> Should be fixed now: (bug#12486).

It's not.

You still have a `flet' in line 176 of `helm-plugin.el'
and a `labels' at line 406 of `helm-utils.el'.

I'm at some Helm version of Sat Oct 27. BTW, wouldn't you add a command
`helm-version'?

[Thierry Volpiatto]

Your emacs is not updated.

[Sebastien Vauban]

Hi Thierry,

Thierry Volpiatto wrote:

> "Sebastien Vauban" a écrit :
>> Thierry Volpiatto wrote:

>>> "Sebastien Vauban" <wxhgmqzgwmuf-geNe...@public.gmane.org> writes:
>>>>
>>>> When using an Emacs snapshot from a couple of days ago (Emacs 24.2.50.1
>>>> of 2012-10-22), I get the following warnings in the Messages buffer:
>>>>
>>>> `labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
>>>> `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or
>>>> `cl-letf'.
>>>
>>> Should be fixed now: (bug#12486).
>>
>> It's not.
>>
>> You still have a `flet' in line 176 of `helm-plugin.el'
>> and a `labels' at line 406 of `helm-utils.el'.
>

> Your emacs is not updated.

I don't understand: Emacs reports we can't use `flet' anymore, and IIUC there
is still one occurrence of it in Helm. Why should I update my Emacs?

>> I'm at some Helm version of Sat Oct 27. BTW, wouldn't you add a command
>> `helm-version'?

What about this? Wouldn't it simplify reporting of problems?