Can ELMAH use context.User instead of Thread.CurrentPrincipal.Identity.Name when getting user name?

[Rinat Abdullin]

Hi,

ELMAH is a really great tool that saves a lot of effort in exception
logging. Thank you for developing it!

I have on question, though. Can ELMAH use context.User instead of
Thread.CurrentPrincipal.Identity.Name when getting user name in the
Error constructor?

AFAIK, generally it is a better practice in web applications to use
the first approach instead of asking for CurrentPrincipal.

Best regards,
Rinat Abdullin

[Atif Aziz]

>>
AFAIK, generally it is a better practice in web applications to use
the first approach instead of asking for CurrentPrincipal.
<<

In general, ASP.NET propagates HttpContext.User to Thread.CurrentPrincipal so it should be safe to rely on the latter. Nonetheless, you raise a good point and I'll review the decision in the Error constructor. Perhaps HttpContext.User can override the value taken from Thread.CurrentPrincipal where an HttpContext was supplied.

- Atif

[Rinat Abdullin]

Atif,

Thank you!

Best regards,
Rinat Abdullin