No new line at end of file

38 views
Skip to first unread message

alco

unread,
Mar 26, 2012, 10:10:00 AM3/26/12
to elixir-lang-core
Most of the Elixir source files have no new line at the end. My editor
is configured to automatically add those when a file is saved.

Is it OK for this change to show up in pull-requested commits or
should contributors adjust their editor's settings?

José Valim

unread,
Mar 26, 2012, 10:30:46 AM3/26/12
to elixir-l...@googlegroups.com
It is OK.


José Valim
Founder and Lead Developer

Rafael Mendonça França

unread,
Mar 26, 2012, 10:16:10 AM3/26/12
to elixir-l...@googlegroups.com
My editor by default remove the new line at end of file, but the José's editor add those. So I don't know how the best way to solve this but I personally don't like these new lines at the end of file. AFAIK, the only languages that warn the user to add new lines at end of file is the C/C++.

Alexei Sholik

unread,
Mar 26, 2012, 10:35:57 AM3/26/12
to elixir-l...@googlegroups.com
Git also outputs "\No new line at end of file" in the diff view.
--
Best regards
Alexei Sholik
Reply all
Reply to author
Forward
0 new messages