Account Options

  1. Sign in
The old Google Groups will be going away soon.
Switch to the new Google Groups.
Google Groups Home
« Groups Home
Bug in Page's plugin: Friends cannot edit items with Friends Write Access
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
sergiy.kamolov  
View profile  
 More options Feb 1, 9:17 am
From: "sergiy.kamolov" <sergiy.kamo...@gmail.com>
Date: Wed, 1 Feb 2012 06:17:08 -0800 (PST)
Local: Wed, Feb 1 2012 9:17 am
Subject: Bug in Page's plugin: Friends cannot edit items with Friends Write Access
1.Login as user 1 who is a friend with user 2

2.Add a new page with Friends write access, as user 1

3.Login as user 2

4.Open list of Friends' pages

Result: user 2 don't Edit link

Expected result: friends should be able to edit items with Friends
Write Access.

Is it a bug or may be I miss something?

P.S. I found that inside pages_write_permission_check (/mod/pages/
start.php:286) we never checking does current user is a friend of
enitiy's owner or not just check user's access array.
$list = get_access_array($user->guid);

May be we need to add something like that:

if ($user->isFriendsWith($params['entity']->owner_guid)){
                            $list[] = -2;
                        }


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Evan Winslow  
View profile  
 More options Feb 2, 10:29 am
From: Evan Winslow <e...@elgg.org>
Date: Thu, 2 Feb 2012 07:29:40 -0800
Local: Thurs, Feb 2 2012 10:29 am
Subject: Re: [Elgg development] Bug in Page's plugin: Friends cannot edit items with Friends Write Access

Thanks for reporting this. Would you mind putting it in trac?
On Feb 1, 2012 6:17 AM, "sergiy.kamolov" <sergiy.kamo...@gmail.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Sergiy Kamolov  
View profile  
 More options Feb 2, 4:00 pm
From: Sergiy Kamolov <sergiy.kamo...@gmail.com>
Date: Thu, 2 Feb 2012 23:00:19 +0200
Local: Thurs, Feb 2 2012 4:00 pm
Subject: Re: [Elgg development] Bug in Page's plugin: Friends cannot edit items with Friends Write Access

Yes, of course... Please look http://trac.elgg.org/ticket/4349

2012/2/2 Evan Winslow <e...@elgg.org>

--
Best Regards,
Sergiy Kamolov.

God bless you.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »