[Doctrine] #1043: [PATCH] doctrine:build-model under Windows is broken

0 views
Skip to first unread message

Doctrine

unread,
May 15, 2008, 7:12:36 AM5/15/08
to doctri...@googlegroups.com
#1043: [PATCH] doctrine:build-model under Windows is broken
------------------------------+---------------------------------------------
Reporter: bschussek | Owner: jwage
Type: defect | Status: new
Priority: critical | Milestone: 0.11.2
Component: sfDoctrinePlugin | Version: 0.11
Keywords: |
------------------------------+---------------------------------------------
The task doctrine:build-model under Window does not work due to bad
handling of directory separators.

The erroneus code can be found in
sfDoctrinePlugin/lib/task/sfDoctrineBuildModelTask.class.php on line 69:
{{{
{
$plugin = str_replace(sfConfig::get('sf_plugins_dir') . '/', '',
$schema);
$e = explode('/', $plugin);
$plugin = $e[0];
$name = basename($schema);
}}}

The task will work if this code is changed to:
{{{
{
$schema = str_replace('/', DIRECTORY_SEPARATOR, $schema);
$plugin = str_replace(sfConfig::get('sf_plugins_dir') .
DIRECTORY_SEPARATOR, '', $schema);
$e = explode(DIRECTORY_SEPARATOR, $plugin);
$plugin = $e[0];
$name = basename($schema);
}}}

--
Ticket URL: <http://trac.phpdoctrine.org/ticket/1043>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper

Doctrine

unread,
May 15, 2008, 7:14:19 AM5/15/08
to doctri...@googlegroups.com
#1043: [PATCH] doctrine:build-model under Windows is broken
-------------------------------+--------------------------------------------
Reporter: bschussek | Owner: jwage
Type: defect | Status: new
Priority: critical | Milestone: 0.11.0
Component: sfDoctrinePlugin | Version: 0.11
Resolution: | Keywords:
-------------------------------+--------------------------------------------
Changes (by bschussek):

* milestone: 0.11.2 => 0.11.0

--
Ticket URL: <http://trac.phpdoctrine.org/ticket/1043#comment:1>

Doctrine

unread,
May 16, 2008, 8:24:07 PM5/16/08
to doctri...@googlegroups.com
#1043: [PATCH] doctrine:build-model under Windows is broken
-------------------------------+--------------------------------------------
Reporter: bschussek | Owner: jwage
Type: defect | Status: closed
Priority: critical | Milestone: 0.11.0
Component: sfDoctrinePlugin | Version: 0.11
Resolution: fixed | Keywords:
-------------------------------+--------------------------------------------
Changes (by jwage):

* status: new => closed
* resolution: => fixed

Comment:

fixed by http://trac.symfony-project.com/changeset/9019

--
Ticket URL: <http://trac.phpdoctrine.org/ticket/1043#comment:2>
Reply all
Reply to author
Forward
0 new messages