[Django] #20474: Make django.db importable without side-effects on settings

24 views
Skip to first unread message

Django

unread,
May 21, 2013, 7:19:38 AM5/21/13
to django-...@googlegroups.com
#20474: Make django.db importable without side-effects on settings
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database | Keywords:
layer (models, ORM) | Has patch: 1
Severity: Normal | Needs tests: 0
Triage Stage: | Easy pickings: 0
Unreviewed |
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, `django.db` is not importable without triggering settings
configuration, which does harm in certain situations, where imports have
then to happen at runtime. I've set up a branch where this behaviour has
been fixed:

https://github.com/django/django/pull/1193

--
Ticket URL: <https://code.djangoproject.com/ticket/20474>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 22, 2013, 1:19:56 AM5/22/13
to django-...@googlegroups.com
#20474: Make django.db importable without side-effects on settings
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):

* stage: Unreviewed => Accepted


Comment:

I don't see any reason to not accept this.

--
Ticket URL: <https://code.djangoproject.com/ticket/20474#comment:1>

Django

unread,
May 23, 2013, 9:19:55 AM5/23/13
to django-...@googlegroups.com
#20474: Make django.db importable without side-effects on settings
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Database layer | Resolution: fixed

(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"499a745ae1b53614035b9993b148f32d4ce3f138"]:
{{{
#!CommitTicketReference repository=""
revision="499a745ae1b53614035b9993b148f32d4ce3f138"
Fixed #20474 -- Proxied and deprecated django.db.backend
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20474#comment:2>

Django

unread,
May 23, 2013, 9:19:56 AM5/23/13
to django-...@googlegroups.com
#20474: Make django.db importable without side-effects on settings
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master

Component: Database layer | Resolution: fixed
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"6a6bb168be90594a18ab6d62c994889b7e745055"]:
{{{
#!CommitTicketReference repository=""
revision="6a6bb168be90594a18ab6d62c994889b7e745055"
Delayed settings.DATABASE_ROUTERS usage by ConnectionRouter

Refs #20474.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20474#comment:4>

Django

unread,
May 23, 2013, 9:19:56 AM5/23/13
to django-...@googlegroups.com
#20474: Make django.db importable without side-effects on settings
-------------------------------------+-------------------------------------
Reporter: claudep | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master

Component: Database layer | Resolution: fixed
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"2d8c132b187d9dfefe0f409c4fb39b54a6645675"]:
{{{
#!CommitTicketReference repository=""
revision="2d8c132b187d9dfefe0f409c4fb39b54a6645675"
Delayed settings.DATABASES usage by ConnectionHandler

Refs #20474.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20474#comment:3>

Reply all
Reply to author
Forward
0 new messages