[Django Code] #5833: newforms-admin enable registering custom FilterSpecs

[Django Code]

#5833: newforms-admin enable registering custom FilterSpecs
---------------------------+------------------------------------------------
Reporter: Honza_Kral | Owner: nobody
Status: new | Component: Admin interface
Version: newforms-admin | Keywords: newforms admin list_filter filterspec
Stage: Unreviewed | Has_patch: 1
---------------------------+------------------------------------------------
I odified the filterspec definition to allow for users to register their
own filters in admin. The mechanism is simple - I just reverted the order
of the registry so that newly registered specs will come first. That way
if you register your own filter via {{{FilterSpec.register}}}, it will be
used before the default one.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

[Django Code]

#5833: newforms-admin enable registering custom FilterSpecs

-----------------------------------------------------+----------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Component: Admin interface
Version: newforms-admin | Resolution:

Keywords: newforms admin list_filter filterspec | Stage: Unreviewed

Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
-----------------------------------------------------+----------------------
Changes (by jkocherhans):

* owner: nobody => jkocherhans
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0

Comment:

I really like the idea behind this, but I'd need to review the code closer
and won't take the time to do it right now since it's a new feature. I'd
rather focus on bugs preventing newforms-admin from being used.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:1>

[Django Code]

#5833: newforms-admin enable registering custom FilterSpecs

-----------------------------------------------------+----------------------
Reporter: Honza_Kral | Owner: jkocherhans

Status: assigned | Component: Admin interface
Version: newforms-admin | Resolution:

Keywords: newforms admin list_filter filterspec | Stage: Unreviewed

Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
-----------------------------------------------------+----------------------

Comment (by Honza_Kral):

Also see #3400 for another ideas about filters which could benefit from
this scheme...

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:2>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
--------------------------------------------------+-------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Component: Admin interface
Version: newforms-admin | Resolution:
Keywords: nfa-someday list_filter filterspec | Stage: Design decision needed

Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0

--------------------------------------------------+-------------------------
Changes (by anonymous):

* stage: Unreviewed => Design decision needed

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:8>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
--------------------------------------------------+-------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Component: Admin interface
Version: newforms-admin | Resolution:
Keywords: nfa-someday list_filter filterspec | Stage: Design decision needed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
--------------------------------------------------+-------------------------

Comment (by jacob):

^^^ that was me; sorry.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:9>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
-----------------------------------------------------------------+----------

Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Component: Admin interface
Version: newforms-admin | Resolution:

Keywords: nfa-someday list_filter filterspec nfa-changelist | Stage: Design decision needed

Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0

-----------------------------------------------------------------+----------
Changes (by ales_zoulek):

* keywords: nfa-someday list_filter filterspec => nfa-someday
list_filter filterspec nfa-changelist

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:10>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: Admin interface | Version: newforms-admin

Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008

Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |

---------------------------------------------+------------------------------
Changes (by Honza_Kral):

* keywords: nfa-someday list_filter filterspec nfa-changelist => nfa-
someday list_filter filterspec nfa-changelist
ep2008

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:12>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: Admin interface | Version: SVN

Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------+------------------------------

Changes (by Alex):

* version: newforms-admin => SVN

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:13>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: Admin interface | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0

Needs_better_patch: 1 |
---------------------------------------------+------------------------------
Changes (by elwaywitvac <elway...@gmail.com>):

* needs_better_patch: 0 => 1

Comment:

{{{
Honza_Kral: I modified the filterspec definition to allow for users to

register their own filters in admin. The mechanism is simple - I just
reverted the order of the registry so that newly registered specs will
come first. That way if you register your own filter via

FilterSpec.register, it will be used before the default one.
}}}
I'm not sure having a reversed registry is intuitive. It certainly makes
overriding FilterSpecs simple. Except if I were to register two
FilterSpecs I would expect them to be tested the order I add them, the
same way it is done in the rest of Django. Maybe the FilterSpec's should
be in a Priority Queue instead of a Queue?

I had created a solution which doesn't reverse the registry ticket:8330.
But I'm realizing now that this wouldn't allow for overriding other
filters like Boolean. I'll keep playing.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:14>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: Admin interface | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Comment (by elwaywitvac <elway...@gmail.com>):

Suggestion: make FieldFilterSpec's similar to how widgets work in
newforms admin.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:15>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: Admin interface | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by Guilherme M. Gondim <sem...@taurinus.org>):

* cc: sem...@taurinus.org (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:16>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: Admin interface | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by korpios):

* cc: kor...@korpios.com (removed)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:17>

[Django Code]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: Admin interface | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by anonymous):

* cc: and...@pelme.se (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:18>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: django.contrib.admin | Version: SVN

Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by fas):

* cc: mbe...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:19>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Comment (by fas):

Based on korpios' idea I made a patch that takes the idea further. With
korpios' current solution you can add custom filters but not play with the
queryset. Filters only based on field lookups is too little for complex
administrations.

I provide a patch which lets you add, like korpios' suggested, custom
filters like this:

{{{
list_filter = (
'field1',
('field2', SomeFieldFilterSpec),
SomeFilterSpec,
)
}}}

Furthermore, every FilterSpec can implement get_query_set:
{{{
def SomeFilterSpec:
def get_query_set(self, cl, qs):
if self.params.has_key("custom_get_parameter"):
return qs.filter(somefield__startswith =
self.params["custom_get_parameter"])
}}}

Note that this is a trivial example that can also be achieved with field
lookup parameters. But there are no limits of how to filter the result
set.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:20>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by yuejie):

* cc: cheny...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:21>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by anonymous):

* cc: bped...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:22>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Comment (by anonymous):

line 103 of filterspec_with_custom_queryset_against_1_0.diff
should read:
{{{
+ super(RelatedFilterSpec, self).__init__(request, params, model,
model_admin, f)
}}}

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:23>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by gerdemb):

* cc: django...@ibeni.net (added)

Comment:

I believe there is a small bug with this patch. Line 31 of
filterspec_with_custom_queryset_against_1_0.diff should be indented once
more so that get_field() is only called when a field is defined in the
list_filter. In the case that the list_filter item is a single callable
item, the field variable is not set and get_field() should not be called
for verification.

Also, any word on if this feature will make it into 1.1? I notice that
there is no implemented listed on the status page. I'm using this feature
frequently in my application, and would prefer to run a released version
of Django instead of patching. :)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:24>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by niels):

* cc: niels...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:25>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by xtrqt):

* cc: jan.rz...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:26>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Comment (by gerdemb):

New path is diff versus v1.0.2 of django and includes fixes mentioned in
the following comments:

10/08/08 20:08:44 changed by anonymous ¶
12/12/08 09:58:24 changed by gerdemb ¶

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:27>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Changes (by kmike):

* cc: kmi...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:28>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------

Comment (by gerdemb):

I updated the patch to the latest HEAD and fixed the TODO comments. In
order to pass the existing tests, I had to disable the use of custom GET
params. In the original patch, the filterspec could consume a custom param
and then return an arbitrary queryset based on this parameter, but to do
this it silently removed the parameters that don't match a field name from
the request. The problem is that there is a test to insure that any
parameters that do not match field names are handled by forwarding to ?e=1
(testIncorrectLookupParameters) which failed when the previous patch
silently removed them. Additionally, the code in the previous patch didn't
handle filters on M2M relationships through an intermediate table because
it assumed the first part of the search param would be a field name.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:29>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------+------------------------------
Comment (by gerdemb):

Developer discussion here: http://groups.google.com/group/django-
developers/browse_thread/thread/eb08729417d50ef3

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:30>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------

Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008

Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by ean...@gmail.com):

* cc: ean...@gmail.com (added)
* needs_better_patch: 1 => 0
* needs_tests: 0 => 1
* stage: Design decision needed => Accepted

Comment:

I am attaching a new patch against the latest HEAD. It's based on
gerdemb's patch but now allows for consuming of GET parameters to allow
for custom, non-field based querystring keys. The patch also implements a
priority queue in a sense; FieldFilterSpec.register() allows you to pass
in high_priority=True in order to register the FieldFilterSpec as high
priority. This argument is True by default but passed in as False for all
default filter specs. High priority specs are inserted before normal
priority specs, but order is preserved amongst the two separate groups.
Let me know what you think of that solution.

I'm also moving this to Accepted since it's on the 1.1 features list
(forgive me if this is an incorrect decision). Also flagging it as Needs
tests.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:31>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by ean...@gmail.com):

Please see 5833-against-9836-new-proper.patch and not
5833-against-9836-new.patch; I accidently diffed some additional,
unrelated changes, and couldn't get trac to replace the old attachment.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:32>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by kmtracey):

I deleted the 5833-against-9836-new.patch to avoid confusion.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:33>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by gonz):

* cc: gonz (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:34>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by niels):

* cc: niels...@gmail.com (removed)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:35>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans

Status: assigned | Milestone: 1.1 beta

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by jacob):

* milestone: => 1.1 beta

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:36>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.1 beta
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: cia...@mbnet.fi (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:37>

[Django]

#5833: [newforms-admin] Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.1 beta
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by rvdrijst):

* cc: rvdrijst (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:38>

[Django]

#5833: Custom FilterSpecs

-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.1 beta
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1

Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by kmtracey):

* needs_docs: 0 => 1
* summary: [newforms-admin] Custom FilterSpecs => Custom FilterSpecs

Comment:

I don't see any documentation for this enhancement in any of the patches?
Makes it hard to gets started on reviewing the code. In the absence of
doc, tests would also at least show how the new function is intended to be
used, but those too are still missing. If anyone who has worked on the
patches here or has an interest in seeing this done could provide some of
these missing pieces, that would help move this one along.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:39>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by jacob):

* milestone: 1.1 beta =>

Comment:

Without docs and tests, and with 1.1 feature freeze coming up soon, this
isn't going to make 1.1.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:40>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by Honza_Kral):

Replying to [comment:40 jacob]:

> Without docs and tests, and with 1.1 feature freeze coming up soon, this
isn't going to make 1.1.

I would like to get this committed, we can work on it during the PyCON
sprint. It is really important for us that this ticket or #3400 gets into
1.1 and we are ready to put some work into it.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:41>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by brosner):

The feature freeze is tomorrow. Only bug fixes will be happening during
the sprints at PyCon. I'm afraid this is just going to have to wait until
1.2.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:42>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans

Status: assigned | Milestone: 1.2

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by mrts):

* milestone: => 1.2

Comment:

Re-targeting for 1.2.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:43>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by eppsilon):

* cc: eppsilon (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:44>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: ram...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:45>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by anonymous):

* cc: pei...@ya.ru (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:46>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by marcob):

* cc: marc...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:47>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: da...@reynoldsfamily.org.uk (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:48>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by anonymous):

* cc: sciy...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:49>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by sciyoshi):

The validation in the latest patch is broken. Attaching a new version
against 1.1/SVN which also fixes #11771.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:50>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by marcob):

When you delete a record, querystring looses return_to_ parameter.

(BTW last patch seems not working for me)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:51>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by anonymous):

Another place where it would be likeable to keep the filters are with
admin actions

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:52>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by velmont):

* cc: velmont (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:53>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: seanl (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:54>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:55>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by alexkoshelev):

* cc: alexkoshelev (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:56>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by marinho):

* cc: marinho (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:57>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by danfairs):

* cc: danfairs (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:58>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by vrehak):

Just a small note: the patch 5883.patch should be modified in
django/contrib/admin/views/main.py, line 200.

Currently it reads:

{{{
if new_qs:
}}}

which fails if new_qs is empty QuerySet (i.e. the filters output is
empty). It works for me if I change it to

{{{
if new_qs is not False:
}}}

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:59>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by russellm):

#12173 raised the issue of ORs in filterspecs.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:60>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.2
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: rman...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:61>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by ubernostrum):

* milestone: 1.2 =>

Comment:

1.2 is feature-frozen, moving this feature request off the milestone.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:62>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by broderboy):

* cc: timothy...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:63>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by manfre):

* cc: manfre (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:64>

Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To post to this group, send email to django-...@googlegroups.com.
To unsubscribe from this group, send email to django-update...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-updates?hl=en.

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by dominicrodger):

* cc: inte...@dominicrodger.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:65>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by isometry):

* cc: isometry (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:66>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by bendavis78):

* cc: benda...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:67>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by bendavis78):

It seems that the latest patch did not support using a "field-less"
filterspec. The validation was failing because it was still expecting a
field. I've attached a patch against 1.2.1 that works for me. If anyone
involved could please test this out, that would be great.

We need some docs and tests for this -- it'd be nice to see this added to
1.3. Although, it would be good to get some feedback from the core devs
to make sure this is going in the right direction.

In the meantime, here's a silly little example of how a custom non-field-
specific filterspec can be used (in case anyone wants to play around with
it).
{{{
#!python
from testapp import models
from django.contrib.admin.filterspecs import FilterSpec
from django.contrib import admin
from django.utils.datastructures import SortedDict

class HowYummyFilterSpec(FilterSpec):
def __init__(self, request, params, model, model_admin):
super(HowYummyFilterSpec, self).__init__(request, params, model,
model_admin)
self.links = SortedDict((
('All', 'all'),
('Double Rainbow', 'so_intense'),
('Pretty good', 'good'),
('Not great', 'not_great'),
('Gross', 'gross'),
))

def consumed_params(self):
return self.links.values()

def choices(self, cl):
selected = [v for v in self.links.values() if
self.params.has_key(v)]
for title, key in self.links.items():
yield {'selected': self.params.has_key(key),
'query_string': cl.get_query_string({key:1}, selected),
'display': title}

def get_query_set(self, cls, qs):
if self.params.has_key('so_intense'):
return qs.filter(name__icontains='bacon')
if self.params.has_key('good'):
return qs.filter(name__icontains='burger')
if self.params.has_key('not_great'):
return qs.filter(name__icontains='haggas')
if self.params.has_key('gross'):
return qs.filter(name__icontains='guano')

return qs

def title(self):
return u'How yummy?'

class FoodAdmin(admin.ModelAdmin):
list_filter = [HowYummyFilterSpec]

admin.site.register(models.Food, FoodAdmin)
}}}

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:68>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by bendavis78):

There was an issue when get_query_set returned an empty queryset, fixed in
latest patch.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:69>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by 3point2):

* cc: 3point2 (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:70>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by 3point2):

just wanted to +1 this, I think it would be a powerful feature (and I have
a current need for it)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:71>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: SafPlusPlus (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:72>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by anonymous):

* cc: krasn...@gmail.com (added)

Comment:

Replying to [ticket:5833 Honza_Kral]:
> One should be able to create custom `FilterSpecs` for the admin's
`list_filter` interface.
>
> Honza_Kral: I modified the filterspec definition to allow for users to
register their own filters in admin. The mechanism is simple - I just
reverted the order of the registry so that newly registered specs will
come first. That way if you register your own filter via
{{{FilterSpec.register}}}, it will be used before the default one.
>
> Another approach by korpios is described in the comments.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:73>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by subsume):

* cc: sub...@gmail.com (added)

Comment:

One problem I have with this--and this may be completely irrelevant, is
the get_query_set method.

The problem I see is that it accepts and returns a filtered queryset and
these FilterSpecs chain like so:

Model.objects.filter(x=y).filter(z=y).filter(a=y)

When it comes to related objects, this is a problem because:

Model.objects.filter(x__z=y).filter(x__y=z).filter(y__x=a)

...is not the same as:

Model.objects.filter(Q(x__z=y)&Q(x__y=z)&Q(y__x=a))

One solution may be to allow get_query_set to return a Q() object and then
string them together as above. Sure, you're still locked into a chain of
&-joined Q objects but you already are and it could be the stuff of future
tickets.

If there's a better place to have this discussion please forward me along.
=). Thanks.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:74>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by fas):

Can you please give a concrete example where multiple filter spec are used
in such a way that it causes a problem?

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:75>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by subsume):

Multiple filter specs won't become a problem until this feature is
implemented. Right now, list_filter only accepts fields on the model in
question. With this proposal FilterSpecs will now be opened up to conduct
querying on related fields.

Concrete example: Take a situation where you have Person and related to it
is a StaffContact. You have Person registered in Admin and you create two
FilterSpecs, one called 'Contacted by' (which looks at the user field of
StaffContact) and another called 'Contact range' (which looks at the field
of StaffContact). Using these two fields together based on this
implementation, chained fields can't give you all Person objects who were
contacted by BOTH a particular staff person AND a particular date range,
which might very well be preferable. Two JOINs will be created by this
proposal, whereas you may have wanted one.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:76>

[Django]

#5833: Custom FilterSpecs
---------------------------------------------+------------------------------

Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008

Stage: Design decision needed | Has_patch: 1

Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |

---------------------------------------------+------------------------------
Changes (by subsume):

* stage: Accepted => Design decision needed

Comment:

switched back to design decision needed.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:77>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------

Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008

Stage: Accepted | Has_patch: 1

Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |

-------------------------------------------+--------------------------------
Changes (by subsume):

* stage: Design decision needed => Accepted

Comment:

switched back to accepted.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:78>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by simon29):

* cc: simon29 (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:79>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by dirleyrls):

* cc: dirl...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:80>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by simon29):

See also #8528, which still makes sense even if this patch goes in. It
provides a sensible default for null=True/blank=True fields, by giving the
None option; where this ticket gives full control.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:81>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by vitek_pliska):

* cc: vitek_pliska (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:82>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by brentp):

* cc: bped...@gmail.com (removed)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:83>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by jovanb):

Replying to [comment:69 bendavis78]:

Custom FilterSpec on a Model level instead of field level is frequently
needed feature (ast least in my case), so thumbs-up for this patch.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:84>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by bendavis78):

This patch needs a major overhaul for 1.3. A lot of changes happened with
the fix for #3400, see changeset r14674 for more info.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:85>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by bendavis78):

I took a stab at a patch for 1.3 -- approch w/ caution, YMMV, etc.. The
validation logic seemed somewhat flawed, so I cleaned that up a bit. I
wasn't too sure about whether or not to include subsume's changes. I
think that still needs a little more discussion.

We still need TESTS and DOCUMENTATION on this.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:86>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by subsume):

I can only have so much discussion with myself. You either agree I have
raised a valid limitation or you don't. You agree that my solution is a
comprimising approach to open up more functionality, or you don't. There's
a buzzword for this patch.... stopgap. Nobody has run into this problem
filtering relations? Really? I was asked for examples and I gave them,
then I wrote a patch. I think my changes deserve ample consideration.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:87>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by bendavis78):

I never said they didn't deserve consideration. I guess i'm still not
sure I understand the problem your patch addresses (your example wasn't
very clear to me). It seems to me that returning a queryset is the
cleanest way. I may be wrong, I'm just not convinced otherwise. I'll
look over it some more today.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:88>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by bendavis78):

@subsume, would you be able to provide a more concrete example than the
one you gave earlier (e.g., models and example filterspecs)? It seems to
me that most people would expect multiple filter specs to act like
multiple .filter() calls. Each chain in the queryset further refines the
previous one. Plus, if you take away the ability to modify the queryset,
you're taking away a lot of flexibility (eg, the use of .exclude(),
.extra(), etc...).

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:89>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by subsume):

I can try and say it again plainly: filtering on fields of a related table
will be done in separate JOINs using this method, whereas you may (and
probably did...) only want one. If you try and filter for Companys that
have a Location that is 1) open_saturday=True and 2) zip_code = 90210, the
current approach leaves you in the cold because of how chained filtering
works.

The current syntax is very seductive because of its simplicity but what is
the point of a beautiful API that doesn't give you what you want?

You are not losing any flexibility--its wrong to say you can't use
exclude(), extra(), etc--you most certainly can, its just a matter of
knowing how Q and Q-like objects work (For example: "exclude" is simply
~Q(somefilter=True). Not difficult at all). From the perspective of
filtering records, Q objects and their like are a more mature way to go
about it because of their great mutability.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:90>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by bendavis78):

again, it would really help if you could give a test case (models.py and
admin.py) so we can get a good idea of the problem you're encountering.
For me, chaining the filters together produces the same effect as a &'d Q
objects. I'm still not sure I understand what the actual undesired
outcome is, which is why some concrete examples would help. Sorry, not
trying to be a pain -- just having trouble grasping the issue you're
raising.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:91>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Comment (by bendavis78):

subsume, I went ahead and created a test case for what I _think_ you're
claiming is a problem, and I can't find the problem. You can get the
code here: https://github.com/bendavis78/filter-test . Each of the
filterspecs seems to behave as one would expect. Let me know what I'm
missing.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:92>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by subsume):

Excellent work. I added a test to that github and sent you a pull request
to review.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:93>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by bendavis78):

@subsume, I see what you're getting at. I still, however, think that
yours is a rare use-case. In the case of the Comapnies/Locations example,
I think it would make more sense to just have a !LocationAdmin to filter
on locations. While I still think most developers would want the default
behavior to work like a normal queryset chain, I can see the benefit of
having the option open, so as a compromise I propose we move the querset
processing code out into a different function so that the default behavior
can be overidden:

(from django/contrib/admin/views/main.py, near line 178)
{{{
#!python

def apply_filter_specs(self, qs, lookup_params):
# Let every filter spec modify the qs and params to its liking
for filter_spec in self.filter_specs:
new_qs = filter_spec.get_query_set(self, qs)
if new_qs is not None and new_qs is not False:
qs = new_qs
# Only consume params if we got a new queryset
for param in filter_spec.consumed_params():
try:
del lookup_params[param]
except KeyError:
pass
return qs

def get_query_set(self):
qs = self.root_query_set
lookup_params = self.params.copy() # a dictionary of the query
string
for i in (ALL_VAR, ORDER_VAR, ORDER_TYPE_VAR, SEARCH_VAR,
IS_POPUP_VAR):
if i in lookup_params:
del lookup_params[i]
key = ''
for key, value in lookup_params.items():
if not isinstance(key, str):
# 'key' will be used as a keyword argument later, so
Python
# requires it to be a string.
del lookup_params[key]
lookup_params[smart_str(key)] = value

# if key ends with __in, split parameter into separate values
if key.endswith('__in'):
lookup_params[key] = value.split(',')

# if key ends with __isnull, special case '' and false
if key.endswith('__isnull'):
if value.lower() in ('', 'false'):
lookup_params[key] = False
else:
lookup_params[key] = True

qs = self.apply_filter_specs(qs, lookup_params)

# Apply lookup parameters from the query string.
}}}

In your case, you would be able to override apply_filter_specs in to
change that behavior. By no means am i the authority on this ticket, so
if anyone else can chime with their opinion please do.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:94>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by subsume):

Definitely happy with this. Thanks.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:95>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by spinyol):

* cc: spinyol (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:96>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by charettes):

* cc: charettes (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:97>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by shanx):

* cc: re...@maykinmedia.nl (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:98>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by charettes):

Is this ticket only missing docs and tests?

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:99>

[Django]

#5833: Custom FilterSpecs
-------------------------------------------+--------------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by anonymous):

* cc: rohit.a...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:100>

[Django]

#5833: Custom FilterSpecs
------------------------------------------------+---------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone: 1.3

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008

Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 |
------------------------------------------------+---------------------------
Changes (by anonymous):

* milestone: => 1.3

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:101>

[Django]

#5833: Custom FilterSpecs
------------------------------------------------+---------------------------
Reporter: Honza_Kral | Owner: jkocherhans
Status: assigned | Milestone:

Component: django.contrib.admin | Version: SVN
Resolution: | Keywords: nfa-someday list_filter filterspec nfa-changelist ep2008
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 |
------------------------------------------------+---------------------------

Changes (by russellm):

* milestone: 1.3 =>

Comment:

1.3 feature deadline has passed.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:102>

[Django]

#5833: Custom FilterSpecs
-------------------------------------+-------------------------------------
Reporter: | Owner: jkocherhans
Honza_Kral | Milestone:
Status: assigned | Version: SVN
Component: | Keywords: nfa-someday
django.contrib.admin | list_filter filterspec nfa-
Resolution: | changelist ep2008

Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 |

-------------------------------------+-------------------------------------
Changes (by jgelens):

* cc: jeffrey@… (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:103>

[Django]

#5833: Custom FilterSpecs
-------------------------------------+-------------------------------------
Reporter: | Owner: jkocherhans
Honza_Kral | Milestone:
Status: assigned | Version: SVN
Component: | Keywords: nfa-someday
django.contrib.admin | list_filter filterspec nfa-
Resolution: | changelist ep2008
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------

Comment (by bendavis78):

Patch won't apply to 1.3-rc1. Working on a new patch.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:104>

[Django]

#5833: Custom FilterSpecs
-------------------------------------+-------------------------------------
Reporter: | Owner: jkocherhans
Honza_Kral | Milestone:
Status: assigned | Version: SVN
Component: | Keywords: nfa-someday
django.contrib.admin | list_filter filterspec nfa-
Resolution: | changelist ep2008
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------

Comment (by ramiro):

#15615 (closed as duplicate) asks for the same feature.

--
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:105>