Re: [Django] #15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST

2 views
Skip to first unread message

Django

unread,
May 9, 2011, 2:56:35 PM5/9/11
to django-...@googlegroups.com
#15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST
------------------------------------+----------------------------------
Reporter: goran@… | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: contrib.csrf
Version: SVN | Severity: Normal
Resolution: | Keywords: csrf,ajax,jquery
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+----------------------------------
Changes (by lukeplant):

* easy: => 0


Comment:

I'm dubious about using `settings.hasContent` because it is only
accidental that it does the right thing.

We also can't make the default implementation use things only available in
jQuery 1.5

But we can mention some of these things in the docs.

--
Ticket URL: <http://code.djangoproject.com/ticket/15469#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 9, 2011, 3:06:58 PM5/9/11
to django-...@googlegroups.com
#15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST
------------------------------------+----------------------------------
Reporter: goran@… | Owner: nobody
Type: Bug | Status: closed
Milestone: | Component: contrib.csrf
Version: SVN | Severity: Normal
Resolution: fixed | Keywords: csrf,ajax,jquery
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+----------------------------------
Changes (by lukeplant):

* status: new => closed
* resolution: => fixed


Comment:

In [16191]:
{{{
#!CommitTicketReference repository="" revision="16191"
Fixed #15469 - CSRF token is inserted on GET requests

Thanks to goran for report.
}}}

--
Ticket URL: </ticket/15469#comment:7>

Django

unread,
May 9, 2011, 3:06:50 PM5/9/11
to django-...@googlegroups.com
#15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST
------------------------------------+----------------------------------
Reporter: goran@… | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: contrib.csrf
Version: SVN | Severity: Normal
Resolution: | Keywords: csrf,ajax,jquery
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+----------------------------------

Comment (by lukeplant):

In [16190]:
{{{
#!CommitTicketReference repository="" revision="16190"
Mentioned simplification of AJAX example code in CSRF docs.

Refs #15469. Thanks to aaugustin for the suggestion
}}}

--
Ticket URL: </ticket/15469#comment:6>

Django

unread,
May 9, 2011, 5:37:52 PM5/9/11
to django-...@googlegroups.com
#15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST
------------------------------------+----------------------------------
Reporter: goran@… | Owner: nobody
Type: Bug | Status: closed
Milestone: | Component: contrib.csrf
Version: SVN | Severity: Normal
Resolution: fixed | Keywords: csrf,ajax,jquery
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+----------------------------------

Comment (by lukeplant):

In [16193]:
{{{
#!CommitTicketReference repository="" revision="16193"
[1.3.X] Fixed #15469 - CSRF token is inserted on GET requests


Thanks to goran for report.

Backport of [16191] from trunk.
}}}

--
Ticket URL: </ticket/15469#comment:8>

Django

unread,
May 9, 2011, 5:39:23 PM5/9/11
to django-...@googlegroups.com
#15469: CSRF/Ajax/JQuery - Token is set to be inserted on both GET and POST
------------------------------------+----------------------------------
Reporter: goran@… | Owner: nobody
Type: Bug | Status: closed
Milestone: | Component: contrib.csrf
Version: SVN | Severity: Normal
Resolution: fixed | Keywords: csrf,ajax,jquery
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
------------------------------------+----------------------------------

Comment (by lukeplant):

In [16194]:
{{{
#!CommitTicketReference repository="" revision="16194"
[1.2.X] Fixed #15469 - CSRF token is inserted on GET requests


Thanks to goran for report.

Backport of [16191] from trunk.
}}}

--
Ticket URL: </ticket/15469#comment:9>

Reply all
Reply to author
Forward
0 new messages