Google Groups Home
Help | Sign in
Message from discussion #3400: [patch] Support for lookup separator with list_filter admin option
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Django Code  
View profile
 More options Jan 31 2007, 1:29 am
From: "Django Code" <nore...@djangoproject.com>
Date: Wed, 31 Jan 2007 06:29:02 -0000
Local: Wed, Jan 31 2007 1:29 am
Subject: Re: [Django Code] #3400: [patch] Support for lookup separator with list_filter admin option
#3400: [patch] Support for lookup separator with list_filter admin option
--------------------------------+------------------------------------------ -
   Reporter:  n...@intv.com.au  |                Owner:  adrian                
     Status:  new               |            Component:  Admin interface      
    Version:  SVN               |           Resolution:                        
   Keywords:  list_filter       |                Stage:  Design decision needed
  Has_patch:  1                 |           Needs_docs:  0                    
Needs_tests:  0                 |   Needs_better_patch:  0                    
--------------------------------+------------------------------------------ -
Comment (by n...@intv.com.au):

 Hmm not sure how I didn't notice before, but this breaks the model
 validation in django.core.management:

 {{{
 for fn in opts.admin.list_display:
     try:
         f = opts.get_field(fn)
     except models.FieldDoesNotExist:
         if not hasattr(cls, fn):
             e.add(opts, '"admin.list_display" refers to %r, which isn\'t
 an attribute, method or property.' % fn)
     else:
         if isinstance(f, models.ManyToManyField):
             e.add(opts, '"admin.list_display" doesn\'t support
 ManyToManyFields (%r).' % fn)
 }}}

 Of course, it shouldn't be hard to fix - but is it worth it? This type of
 filtering is very useful for my particular apps but if it's not considered
 common enough for the core there's no point fixing the validation.

--
Ticket URL: <http://code.djangoproject.com/ticket/3400#comment:2>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google