[Django] #12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.

[Django]

#12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.
-------------------------------+--------------------------------------------
Reporter: gabrielhurley | Owner: nobody
Status: new | Milestone: 1.2
Component: Template system | Version: 1.1
Keywords: phone2numeric | Stage: Unreviewed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
-------------------------------+--------------------------------------------
Discussion on the django developers group here:
http://groups.google.com/group/django-
developers/browse_frm/thread/49ee1863efa59901

There doesn't seem to be any good reason for the phone2numeric function
not to convert the letters Q or Z, so I've created a small patch that
remedies that.

Also, for readability's sake the patch puts the dictionary of letter-to-
number conversions in alphabetical order.

--
Ticket URL: <http://code.djangoproject.com/ticket/12613>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.

--------------------------------------+-------------------------------------
Reporter: gabrielhurley | Owner: gabrielhurley
Status: assigned | Milestone: 1.2

Component: Template system | Version: 1.1

Resolution: | Keywords: phone2numeric

Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |

--------------------------------------+-------------------------------------
Changes (by gabrielhurley):

* owner: nobody => gabrielhurley
* status: new => assigned

--
Ticket URL: <http://code.djangoproject.com/ticket/12613#comment:1>

[Django]

#12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.

--------------------------------------+-------------------------------------
Reporter: gabrielhurley | Owner: gabrielhurley

Status: assigned | Milestone: 1.2

Component: Template system | Version: 1.1

Resolution: | Keywords: phone2numeric
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
--------------------------------------+-------------------------------------
Changes (by ericholscher):

* needs_tests: 0 => 1
* stage: Unreviewed => Accepted

Comment:

Could use a test that breaks currently and passes with the patch.

--
Ticket URL: <http://code.djangoproject.com/ticket/12613#comment:2>

[Django]

#12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.

--------------------------------------+-------------------------------------
Reporter: gabrielhurley | Owner: gabrielhurley

Status: assigned | Milestone: 1.2

Component: Template system | Version: 1.1

Resolution: | Keywords: phone2numeric
Stage: Accepted | Has_patch: 1

Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |

--------------------------------------+-------------------------------------
Changes (by gabrielhurley):

* needs_tests: 1 => 0

--
Ticket URL: <http://code.djangoproject.com/ticket/12613#comment:3>

[Django]

#12613: phone2numeric doesn't convert the letters 'Q' or 'Z'.

--------------------------------------+-------------------------------------
Reporter: gabrielhurley | Owner: gabrielhurley

Status: closed | Milestone: 1.2

Component: Template system | Version: 1.1

Resolution: fixed | Keywords: phone2numeric
Stage: Accepted | Has_patch: 1

Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |

--------------------------------------+-------------------------------------
Comment (by russellm):

(In [12425]) Fixed #12613 -- Added Q and Z to the list of characters
supported by the phone2numeric filter. Thanks to gabrielhurley for the
report and patch.

--
Ticket URL: <http://code.djangoproject.com/ticket/12613#comment:5>