#6362: Remove blank spaces with strip when validating the data
---------------------------------+----------------------------------------- -
   Reporter:  marinho            |                Owner:  nobody        
     Status:  new                |            Component:  django.newforms
    Version:  SVN                |           Resolution:                
   Keywords:  blank space strip  |                Stage:  Unreviewed    
  Has_patch:  0                  |           Needs_docs:  0              
Needs_tests:  0                  |   Needs_better_patch:  0              
---------------------------------+----------------------------------------- -
Comment (by akaihola):

 #6717 is about URL fields and leading/trailing spaces specifically.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:4>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------+----------------------------------------- -
   Reporter:  marinho            |                Owner:  nobody                
     Status:  new                |            Component:  django.newforms      
    Version:  SVN                |           Resolution:                        
   Keywords:  blank space strip  |                Stage:  Design decision needed
  Has_patch:  0                  |           Needs_docs:  0                    
Needs_tests:  0                  |   Needs_better_patch:  0                    
---------------------------------+----------------------------------------- -
Changes (by jacob):

  * stage:  Unreviewed => Design decision needed

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:5>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  django.newforms         |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  0                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by zhango):

 * cc: a...@zoomget.com (added)

Comment:

 +1 on this too please.  In usability tests, most of my users accidentally
 entered a space in EmailFields and were baffled when the django-based
 system threw an error at them, since what they typed looks fine to them.
 This happens too often not to be addressed.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:11>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  django.newforms         |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  0                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by nail.xx <nail...@gmail.com>):

 +1 vote. Strip should be performed by default.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:12>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  django.newforms         |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  0                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by nail.xx <nail...@gmail.com>):

 Possible temporary solution is available at
 http://www.djangosnippets.org/snippets/956/. But I'm still sure strip
 should be done by django as default behavior.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:13>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  django.newforms         |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  0                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by julianb):

 +1. Could be made opt-out, if someone really doesn't like it.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:14>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  django.newforms         |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  0                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by mtredinnick):

 Will everybody please stop putting "+1" style comments. They are *totally*
 useless for the purposes of the ticket. Even if 100 people added such a
 comment, that's less than .1% of the userbase, so is entirely non-
 representative. The resolution will be on the merits, not some straw
 count.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:15>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by anonymous):

  * has_patch:  0 => 1

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:16>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by kratorius):

 See also #5714 that basically belongs to this.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:17>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by guettli):

 * cc: h...@tbz-pariv.de (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:18>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by hdevries):

 * cc: bj...@wasda.nl (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:19>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by dc):

 -1 for the normalize(). It's overkill for simple stripping. And for
 complicated normalization better normalize data in form.clean_FIELD() or
 write own field subclass with specialized clean() method.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:20>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:21>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:22>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by olau):

 * cc: o...@iola.dk (added)

Comment:

 I sometimes got email from visitors claiming that the user registration
 form didn't work as it didn't accept their email address. Took quite a
 while to figure out what was wrong. Today I discovered the same problem
 with the shopping cart.

 Adding a {{{clean_email()}}} method to the form to strip the data doesn't
 work as it is run after {{{EmailField}}} does its check. So it's easy to
 do the wrong thing, and it's not straightforward to fix.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:23>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by marinho):

 In my opinion would be simple have an attribute **"keep_blank_spaces"** in
 **forms.CharField**, with defaulf value **False**. Then who wants to keep
 the blank space just set something like this:

 {{{
     field = forms.CharField(max_length=20, keep_blank_spaces=True)
 }}}

 I'm sure most of cases people don't want keep blank spaces at left or
 right of cleaned strings.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:24>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by julianb):

 Replying to [comment:24 marinho]:
 > I'm sure most of cases people don't want keep blank spaces at left or
 right of cleaned strings.

 That might be, but as everyone here was told "Even if 100 people [think
 so], that's less than .1% of the userbase, so is entirely non-
 representative. The resolution will be on the merits, not some straw
 count."

 I'm wondering when that is happening.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:25>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by marinho):

 @julianb

 When I said "most of cases" I wasn't meaning "most of us in this
 discussion", but '''"most of projects made using Django"'''. And for
 exceptional cases, there would be an attribute to set it.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:26>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by anonymous):

 * cc: a...@andybak.net (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:27>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by martin):

 * cc: mar...@akoha.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:28>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by thebitguru):

 * cc: far...@thebitguru.com (added)

Comment:

 I am also looking for a decision on this (ideally, yes, do it).  Posting
 to the django developers group for a decision
 (http://groups.google.com/group/django-developers/t/90352cc0da78390b).

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:29>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Comment (by hdevries):

 2 years after opening this ticket still no decision? Rails' ticket
 management is way, way better than Django's.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:30>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:  1.2              
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by hvdklauw):

  * milestone:  => 1.2

Comment:

 If you call another ticket a duplicate:
 http://code.djangoproject.com/ticket/11907
 At least make sure the original is still looked at...

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:31>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:32>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

#6362: Remove blank spaces with strip when validating the data
---------------------------------------------+----------------------------- -
          Reporter:  marinho                 |         Owner:  nobody          
            Status:  new                     |     Milestone:                  
         Component:  Forms                   |       Version:  SVN              
        Resolution:                          |      Keywords:  blank space strip
             Stage:  Design decision needed  |     Has_patch:  1                
        Needs_docs:  0                       |   Needs_tests:  0                
Needs_better_patch:  0                       |  
---------------------------------------------+----------------------------- -
Changes (by net147):

 * cc: net...@gmail.com (added)

--
Ticket URL: <http://code.djangoproject.com/ticket/6362#comment:33>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.