[Django] #18000: Add Save and Goto Step to Form Wizard
Django
----------------------------------+----------------------------------------
Reporter: creecode | Owner: nobody
Type: New feature | Status: new
Component: | Version: 1.4
contrib.formtools | Keywords: form wizard save goto step
Severity: Normal | Has patch: 1
Triage Stage: Unreviewed | UI/UX: 0
Easy pickings: 0 |
----------------------------------+----------------------------------------
I've been working with the new form wizard in 1.4 and I discovered that
apparently the goto form step feature was designed to not store data from
the current step before going to the step specified.
This seems like a situation that will easily lead to confusion and
frustration. I suggest that in addition to the current cancel and goto
step feature a save and goto step feature is needed.
I created a patch that changes the behavior of wizard_goto_step into a
save and goto, which seems safer to me, and then adds a
wizard_cancel_step_goto.
Please feel free to tinker with the code. I'm happy as long a I get a
little more control over how data is handled when going to another step.
Toodle-looooooooooo..........
creecode
--
Ticket URL: <https://code.djangoproject.com/ticket/18000>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: form wizard save | Triage Stage:
goto step | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by jezdez):
* cc: steph (added)
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:1>
Django
Type: New feature | Status: new
Severity: Normal | Resolution:
goto step | decision needed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: msopacua (added)
* stage: Unreviewed => Design decision needed
Comment:
Needs a decision on whether it's useful. A +1 from me, for what it's worth
;)
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:2>
Django
Reporter: creecode | Owner: nobody
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: form wizard save | Triage Stage: Design
goto step | decision needed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by steph):
I just wrote a bunch of code to make it possible to store the form data
before changing the step. I don't think we should change the default
behaviour because users except that the data is not saved. With this
change any developer can overwrite the render_goto_step method to change
the default behaviour. Please see this commit:
https://github.com/stephrdev/django/commit/1b7e25e0427888af7958f3960c31f42ff1ce3ef2
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:3>
Django
Reporter: creecode | Owner: steph
Type: New feature | Status: assigned
Component: contrib.formtools | Version: 1.4
Severity: Normal | Resolution:
Keywords: form wizard save | Triage Stage: Design
goto step | decision needed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => steph
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:4>
Django
Reporter: creecode | Owner: steph
Type: New feature | Status: assigned
Component: contrib.formtools | Version: 1.4
Severity: Normal | Resolution:
goto step | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Design decision needed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:5>
Django
Reporter: creecode | Owner: steph
Component: contrib.formtools | Version: 1.4
Severity: Normal | Resolution: fixed
Keywords: form wizard save | Triage Stage: Ready for
goto step | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e7514e4978178ba68a872ac0004dd6f8049f3d76"]:
{{{
#!CommitTicketReference repository=""
revision="e7514e4978178ba68a872ac0004dd6f8049f3d76"
Merge pull request #942 from stephrdev/trac-18000
Fixed #18000 -- Moved the code to handle goto requests to an extra
WizardView method.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18000#comment:6>