Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion PISTON_DISPLAY_ERRORS and transaction handling
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Dan Fairs  
View profile  
 More options Feb 26 2010, 8:28 am
From: Dan Fairs <dan.fa...@gmail.com>
Date: Fri, 26 Feb 2010 13:28:41 +0000
Local: Fri, Feb 26 2010 8:28 am
Subject: Re: PISTON_DISPLAY_ERRORS and transaction handling

> Not sure what to do about this. Maybe warn if PISTON_DISPLAY_ERRORS is
> on together with the transaction middleware?

That'd help.

Of course, it's not just the transaction middleware affected by this: it's any middleware that has a process_exception() method. Another possibility therefore might be to have Piston itself invoke process_exception() for all installed middlewares before returning the server error response, mimicking:

django/handlers/base.py:97,101

                for middleware_method in self._exception_middleware:
                    response = middleware_method(request, e)
                    if response:
                        return response
                raise

I haven't investigated far enough to figure out if there would be any other problems with doing that.

I do agree there's also an issue with Django too. I'll post a message on django-users to see what the feeling is about it there.

Cheers,
Dan

--
Dan Fairs <dan.fa...@gmail.com> | http://www.fezconsulting.com/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.