Re: Issue 24 in django-jython: missing files when using jython/doj to create war

[django...@googlecode.com]

Updates:
Status: Accepted
Owner: juneau001

Comment #3 on issue 24 by juneau001: missing files when using jython/doj to
create war
http://code.google.com/p/django-jython/issues/detail?id=24

I will try to address this issue for the next release.

[django...@googlecode.com]

Updates:
Status: Started

Comment #4 on issue 24 by juneau001: missing files when using jython/doj to
create war
http://code.google.com/p/django-jython/issues/detail?id=24

Still an issue while using virtualenv 1.6.4 along with Jython 2.5.2

[Carles Barrobés i Meix]

Hi Josh, since I had been working with the war command in the past, I
could work on this issue if you're short of time.
I'm a fulltime virtualenv user now, it would be useful for me as well ;)

Cheers,
C

[Josh Juneau]

Carles-

That is great to hear.  If you want to take a stab at this item then that would be great.

Time is definitely tight right now, but I am trying to slowly make my way through the list of open issues.  I'd like to resolve the most important ones and then release another beta...within a few weeks would be nice.  My hope is to release another beta before JavaOne.

Thanks Carles

Josh Juneau
june...@gmail.com
http://jj-blogger.blogspot.com
http://www.jythonbook.com
Oracle PL/SQL Recipes - http://www.apress.com/9781430232070

--
You received this message because you are subscribed to the Google Groups "django-jython-dev" group.
To post to this group, send email to django-jython-dev@googlegroups.com.
To unsubscribe from this group, send email to django-jython-dev+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-jython-dev?hl=en.

[django...@googlecode.com]

Comment #5 on issue 24 by car...@barrobes.com: missing files when using

jython/doj to create war
http://code.google.com/p/django-jython/issues/detail?id=24

The current implementation of the war command does the packaging of python
code based on cherry-picking from specific locations instead of caring
about the value of sys.path.

Virtualenv does not copy all of the standard libraries of jython, it copies
some and modifies some other python files (like site.py). Virtualenv does
manipulate sys.path so that the files in the virtualenv *and* the base
jython version can be found.

Maybe what we should do is to rewrite the war command so that it bases the
choice of python files to be packaged on sys.path and nothing else, maybe
letting the user exclude paths that she knows are not used. Then the
nominal case will be to have a well-defined virtualenv with only the
libraries you need, and "war" will package those plus your project files
(project python files should be on sys.path anyway).

[Carles Barrobés i Meix]

I've been taking a look at this issue and added some comments to the ticket:
http://code.google.com/p/django-jython/issues/detail?id=24#c5

My summarised suggestion (it probably needs some more detailed analysis) is to rewrite the war command so that instead of "cherry-picking" the python libraries to include, it bases the decision on sys.path exclusively. That would solve the virtualenv case and possibly simplify others, besides eliminating the current use of __file__ that makes someone nervous (according to a non-attributed comment in the source code).

I'd like to see your views on that approach, especially Leo's since AFAIK he was the original author of the war command and had his reasons for the design decisions made.

For optimised performance maybe I would split this in several commands: one that "prepackages" all dependencies except the specific project files, and another one that builds the war based on these prepackaged dependencies and the project files. The first one is costlier but needn't be run often (unless your dependencies change), the second one should then be considerably faster.

Cheers,
C.

On 13/08/11 15:56, Josh Juneau wrote:

Carles-

That is great to hear.  If you want to take a stab at this item then that would be great.

Time is definitely tight right now, but I am trying to slowly make my way through the list of open issues.  I'd like to resolve the most important ones and then release another beta...within a few weeks would be nice.  My hope is to release another beta before JavaOne.

Thanks Carles

Josh Juneau
june...@gmail.com
http://jj-blogger.blogspot.com
http://www.jythonbook.com
Oracle PL/SQL Recipes - http://www.apress.com/9781430232070

On Fri, Aug 12, 2011 at 2:12 PM, Carles Barrobés i Meix <car...@barrobes.com> wrote:

Hi Josh, since I had been working with the war command in the past, I could work on this issue if you're short of time.
I'm a fulltime virtualenv user now, it would be useful for me as well ;)

Cheers,
C

On 10/08/11 16:23, django...@googlecode.com wrote:

Updates:
   Status: Started

Comment #4 on issue 24 by juneau001: missing files when using jython/doj to create war
http://code.google.com/p/django-jython/issues/detail?id=24

Still an issue while using virtualenv 1.6.4 along with Jython 2.5.2

--
You received this message because you are subscribed to the Google Groups "django-jython-dev" group.

To post to this group, send email to django-j...@googlegroups.com.
To unsubscribe from this group, send email to django-jython-...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/django-jython-dev?hl=en.

--
You received this message because you are subscribed to the Google Groups "django-jython-dev" group.

To post to this group, send email to django-j...@googlegroups.com.
To unsubscribe from this group, send email to django-jython-...@googlegroups.com.

[Leo Soto M]

I fully agree with rewriting the command and base it on sys.path. Oh, and the comment was mine :)

Enviado desde mi iPhone

[Josh Juneau]

Thanks Carles and Leo, sounds like a good approach to me.

Josh Juneau
june...@gmail.com
http://jj-blogger.blogspot.com
http://www.jythonbook.com
Oracle PL/SQL Recipes - http://www.apress.com/9781430232070

[car...@barrobes.com]

hahaha I was guessing so about the comment :)
thanks for the feedback!

S'està citant Leo Soto M <leo....@gmail.com>:

[django...@googlecode.com]

Updates:
Owner: carles.b...@gmail.com

Comment #6 on issue 24 by juneau001: missing files when using jython/doj to
create war
http://code.google.com/p/django-jython/issues/detail?id=24

Changing Carles to the owner of this item.

[django...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 24 by andr...@st0cker.at: missing files when using

jython/doj to create war
http://code.google.com/p/django-jython/issues/detail?id=24

Should not be an issue any more since the rewrite of django-jython.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings