On Fri, 2008-08-29 at 10:23 -0700, Nuno Mariz wrote: > Just submitted a patch for the Portuguese translation: > http://code.djangoproject.com/ticket/8685 > I think was not updated since 0.96 version
So, a couple of things for the future (and this applies to everybody, not just you, but it was your patches I was just committing)...
Don't take what follows the wrong way. You did a full translation. It applied without problems and is now in 1.0. I am very appreciative of the hard work you've done and you have my thanks (and those of people using Django in Portugese). I am writing here for the general audience, not just you, Nuno:
The preferred format, even for translations, is a diff against the current SVN. That makes it a lot easier to check that you are indeed patching the correct files against a recent version. People who attach the whole file make that harder to sanity check (and, yes, mistakes happen, so the sanity check is useful). Don't worry when Trac doesn't display your patch correctly. That's a bug in Trac. It's still attached and I can still download the original format and apply it. That's a horrible user interface problem in Trac, I agree, but once you just trust that your patch is attached properly, it becomes easier. If there's a problem, we'll let you know.
I know you attached two patches, but this is the second point. Patch files are awesome. A single file can patch multiple source files at once. So *one* patch file is the recommended maximum. :-)
Start at the top of the source tree (the directory you checked out of subversion) and run "svn diff > translation-update.diff".
The advantage of this is that then the patch file contains the full path to the files being patched. If you create the diff inside the locale directory (e.g. inside pt/LC_MESSAGES/), I -- or whoever does the commits -- has to work out which locale is being patched and move to the right directory. This isn't as easy as you might expect. Okay, Portugese is "pt", that's not too hard to remember. But Georgian is "ka", Irish is "ga" and there's a very subtle difference between "zh_CN" and "zh_TW". Remember that we don't all speak your language.
So, for everybody: don't make the committers have to guess. We're not very smart. We make mistakes. A lot. Please help us! :-)
Despite all this, I realise it's a bit of a tedious process sometimes. We're not going to reject translations just because people make a few process mistakes. Sometimes we might ask for another submission, but we always want translations. So thankyou to everybody who is doing the hard work to get these things up to date.
Interesting fact: Over half of the visitors to djangoproject.com have a language other than English set as the preference in their browser. So we already reach a wide international audience. You guys can take a lot of the credit for that.
> On Fri, 2008-08-29 at 10:23 -0700, Nuno Mariz wrote:
> > Just submitted a patch for the Portuguese translation:
> >http://code.djangoproject.com/ticket/8685 > > I think was not updated since 0.96 version
> So, a couple of things for the future (and this applies to everybody,
> not just you, but it was your patches I was just committing)...
> Don't take what follows the wrong way. You did a full translation. It
> applied without problems and is now in 1.0. I am very appreciative of
> the hard work you've done and you have my thanks (and those of people
> using Django in Portugese). I am writing here for the general audience,
> not just you, Nuno:
> The preferred format, even for translations, is a diff against the
> current SVN. That makes it a lot easier to check that you are indeed
> patching the correct files against a recent version. People who attach
> the whole file make that harder to sanity check (and, yes, mistakes
> happen, so the sanity check is useful). Don't worry when Trac doesn't
> display your patch correctly. That's a bug in Trac. It's still attached
> and I can still download the original format and apply it. That's a
> horrible user interface problem in Trac, I agree, but once you just
> trust that your patch is attached properly, it becomes easier. If
> there's a problem, we'll let you know.
> I know you attached two patches, but this is the second point. Patch
> files are awesome. A single file can patch multiple source files at
> once. So *one* patch file is the recommended maximum. :-)
> Start at the top of the source tree (the directory you checked out of
> subversion) and run "svn diff > translation-update.diff".
> The advantage of this is that then the patch file contains the full path
> to the files being patched. If you create the diff inside the locale
> directory (e.g. inside pt/LC_MESSAGES/), I -- or whoever does the
> commits -- has to work out which locale is being patched and move to the
> right directory. This isn't as easy as you might expect. Okay, Portugese
> is "pt", that's not too hard to remember. But Georgian is "ka", Irish is
> "ga" and there's a very subtle difference between "zh_CN" and "zh_TW".
> Remember that we don't all speak your language.
> So, for everybody: don't make the committers have to guess. We're not
> very smart. We make mistakes. A lot. Please help us! :-)
> Despite all this, I realise it's a bit of a tedious process sometimes.
> We're not going to reject translations just because people make a few
> process mistakes. Sometimes we might ask for another submission, but we
> always want translations. So thankyou to everybody who is doing the hard
> work to get these things up to date.
> Interesting fact: Over half of the visitors to djangoproject.com have a
> language other than English set as the preference in their browser. So
> we already reach a wide international audience. You guys can take a lot
> of the credit for that.
> Best wishes,
> Malcolm
Ok Malcolm,
Sorry about the messy patching, note taken.
Should I submit another ticket with this process?
> On Aug 29, 6:58 pm, Malcolm Tredinnick <malc...@pointy-stick.com>
> wrote:
> > On Fri, 2008-08-29 at 10:23 -0700, Nuno Mariz wrote:
> > > Just submitted a patch for the Portuguese translation:
> > >http://code.djangoproject.com/ticket/8685 > > > I think was not updated since 0.96 version
> > So, a couple of things for the future (and this applies to everybody,
> > not just you, but it was your patches I was just committing)...
> > Don't take what follows the wrong way. You did a full translation. It
> > applied without problems and is now in 1.0. I am very appreciative of
> > the hard work you've done and you have my thanks (and those of people
> > using Django in Portugese). I am writing here for the general audience,
> > not just you, Nuno:
> > The preferred format, even for translations, is a diff against the
> > current SVN. That makes it a lot easier to check that you are indeed
> > patching the correct files against a recent version. People who attach
> > the whole file make that harder to sanity check (and, yes, mistakes
> > happen, so the sanity check is useful). Don't worry when Trac doesn't
> > display your patch correctly. That's a bug in Trac. It's still attached
> > and I can still download the original format and apply it. That's a
> > horrible user interface problem in Trac, I agree, but once you just
> > trust that your patch is attached properly, it becomes easier. If
> > there's a problem, we'll let you know.
> > I know you attached two patches, but this is the second point. Patch
> > files are awesome. A single file can patch multiple source files at
> > once. So *one* patch file is the recommended maximum. :-)
> > Start at the top of the source tree (the directory you checked out of
> > subversion) and run "svn diff > translation-update.diff".
> > The advantage of this is that then the patch file contains the full path
> > to the files being patched. If you create the diff inside the locale
> > directory (e.g. inside pt/LC_MESSAGES/), I -- or whoever does the
> > commits -- has to work out which locale is being patched and move to the
> > right directory. This isn't as easy as you might expect. Okay, Portugese
> > is "pt", that's not too hard to remember. But Georgian is "ka", Irish is
> > "ga" and there's a very subtle difference between "zh_CN" and "zh_TW".
> > Remember that we don't all speak your language.
> > So, for everybody: don't make the committers have to guess. We're not
> > very smart. We make mistakes. A lot. Please help us! :-)
> > Despite all this, I realise it's a bit of a tedious process sometimes.
> > We're not going to reject translations just because people make a few
> > process mistakes. Sometimes we might ask for another submission, but we
> > always want translations. So thankyou to everybody who is doing the hard
> > work to get these things up to date.
> > Interesting fact: Over half of the visitors to djangoproject.com have a
> > language other than English set as the preference in their browser. So
> > we already reach a wide international audience. You guys can take a lot
> > of the credit for that.
> > Best wishes,
> > Malcolm
> Ok Malcolm,
> Sorry about the messy patching, note taken.
> Should I submit another ticket with this process?
I entirely agree with you Malcolm. There must be quite a few people who 'upload a complete new .po files to Trac', I guess. That is because in the Localization page[1], there are description about how to update translations, and said that 'upload a complete new .po files to Trac'.
1. Ensure that you are running the latest subversion checkout of the code - run "svn update" in your local django subversion copy. 2. Run django-admin.py makemessages -l <locale> and you get updated .po files 3. Update any untranslated and fuzzy messages with your favorite translation tool. Anything that looks like "%s" or "%(something)s" has to be copied precisely and the 's' may be a 'd' or 'x' or 'i', possibly. 4. Run django-admin.py compilemessages -l <locale> and ensure there are no errors. 5. Upload the complete new .po files to Trac. --- quote
How about changing this description? Just a suggestion :-)
On Sat, 2008-08-30 at 08:54 +0900, Takashi Matsuo wrote: > Hi Malcolm,
> I entirely agree with you Malcolm. There must be quite a few people > who 'upload a complete new .po files to Trac', I guess. That is > because in the Localization page[1], there are description about how > to update translations, and said that 'upload a complete new .po files > to Trac'.
[...]
> How about changing this description?
By all means feel free to change it. It's a wiki, so there for anybody to edit.
I also want to put a proper section in the contributing documentation for the docs that ship with Django, since the wiki is mostly user-contributed stuff, whereas the documentation in Django itself is a bit more tightly edited. That (updating contributing) I will make time to do before 1.0. But I have a lot on my list to do before next Tuesday, so updating the wiki isn't anywhere on that list.
> On Sat, 2008-08-30 at 08:54 +0900, Takashi Matsuo wrote: >> Hi Malcolm,
>> I entirely agree with you Malcolm. There must be quite a few people >> who 'upload a complete new .po files to Trac', I guess. That is >> because in the Localization page[1], there are description about how >> to update translations, and said that 'upload a complete new .po files >> to Trac'.
> [...] >> How about changing this description?
> By all means feel free to change it. It's a wiki, so there for anybody > to edit.
Done :-)
> I also want to put a proper section in the contributing documentation > for the docs that ship with Django, since the wiki is mostly > user-contributed stuff, whereas the documentation in Django itself is a > bit more tightly edited. That (updating contributing) I will make time > to do before 1.0. But I have a lot on my list to do before next Tuesday, > so updating the wiki isn't anywhere on that list.
> On Sat, 2008-08-30 at 08:54 +0900, Takashi Matsuo wrote: >> Hi Malcolm,
>> I entirely agree with you Malcolm. There must be quite a few people >> who 'upload a complete new .po files to Trac', I guess. That is >> because in the Localization page[1], there are description about how >> to update translations, and said that 'upload a complete new .po files >> to Trac'.
> [...] >> How about changing this description?
> By all means feel free to change it. It's a wiki, so there for anybody > to edit.
> I also want to put a proper section in the contributing documentation > for the docs that ship with Django, since the wiki is mostly
