Wrong default behavior in PageAdmin's add_extension_options function?

[sspross]

Hey everybody

I want to create a page extension which is not displayed in collapse mode. So this is not possible atm, because the default behavior adds a 'collabse' class everytime.

I think we can remove this line: https://github.com/sspross/feincms/commit/e6af1bc9bea1c036a26d6f18a154405b26320cb1

The including extensions, e.g. 'titles', adds the class already: https://github.com/feincms/feincms/blob/master/feincms/module/page/extensions/titles.py#L45

Did I miss something or am I right?

This behavior exists in the ExtensionModelAdmin class too, jfyi: https://github.com/sspross/feincms/blob/master/feincms/extensions.py#L197

If we change this default behavior, I think we have to tell everybody in the release notes about this.

What do you think?

[Matthias Kestenholz]

Hi

Yes, I think we should remove this line.

We might stay more backwards compatible by still adding the ``collapse`` class unconditionally in ``LegacyExtension``. This would mean that you'd absolutely have to upgrade your code to use ``feincms.extensions.Extension`` if you want an uncollapsed fieldset for your extension.

Does that sound good?

Thanks

Matthias