Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Django developers
Home
+ new post
About this group
Join this group
Message from discussion Feature request: collectstatic shouldn't recopy files that already exist in destination
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Dan Loewenherz  
View profile  
 More options Sep 27 2012, 6:54 pm
From: Dan Loewenherz <d...@dlo.me>
Date: Thu, 27 Sep 2012 15:47:17 -0700
Local: Thurs, Sep 27 2012 6:47 pm
Subject: Re: Feature request: collectstatic shouldn't recopy files that already exist in destination
Print | View thread | Show original | Report this message | Find messages by this author

Just updated the ticket.

As I commented, the heuristic for checking if a file has been modified lies
in line 282 of collectstatic.py:

*if not prefixed_path in self.copied_files:*
*
return self.log("Skipping '%s' (already copied earlier)" % path)

*
https://github.com/django/django/blob/master/django/contrib/staticfil...

This seems off, since a path may stay the same but a file's contents may
change.

Also, the existing functionality doesn't work when multiple people are
running collectstatic (or the same person is running it on multiple
computers).

Dan

On Thu, Sep 27, 2012 at 3:12 PM, Karen Tracey <kmtra...@gmail.com> wrote:
> On Thu, Sep 27, 2012 at 12:51 PM, Dan Loewenherz <dloewenh...@gmail.com>wrote:

>> The problem I've run into is that collectstatic copies all files,
>> regardless of whether they already exist on the destination.

> No, as noted in the ticket, which has been closed needsinfo, staticfiles
> already only copies modified files. And I don't think that's a
> recently-added feature, so I suspect the behavior you are seeing has more
> to do with the S3 side than the staticfiles code. This post:

> http://stackoverflow.com/questions/6618013/django-staticfiles-and-ama...

> looks enlightening though even that is not all that new. It sounds like
> the problem here is efficiently getting the last-modified time for the
> files out in S3, not with staticfiles.

> Karen

>  --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google