Message from discussion
Low-Hanging Fruit
Received: by 10.150.241.1 with SMTP id o1mr404731ybh.87.1271688593779;
Mon, 19 Apr 2010 07:49:53 -0700 (PDT)
X-BeenThere: django-developers@googlegroups.com
Received: by 10.101.168.36 with SMTP id v36ls10777241ano.4.p; Mon, 19 Apr 2010
07:49:46 -0700 (PDT)
Received: by 10.90.20.28 with SMTP id 28mr2115238agt.7.1271688586704;
Mon, 19 Apr 2010 07:49:46 -0700 (PDT)
Received: by 10.90.20.28 with SMTP id 28mr2115237agt.7.1271688586628;
Mon, 19 Apr 2010 07:49:46 -0700 (PDT)
Return-Path: <kmtra...@gmail.com>
Received: from mail-gw0-f45.google.com (mail-gw0-f45.google.com [74.125.83.45])
by gmr-mx.google.com with ESMTP id 25si579900ywh.15.2010.04.19.07.49.45;
Mon, 19 Apr 2010 07:49:45 -0700 (PDT)
Received-SPF: pass (google.com: domain of kmtra...@gmail.com designates 74.125.83.45 as permitted sender) client-ip=74.125.83.45;
Received: by gwj16 with SMTP id 16so589081gwj.32
for <django-developers@googlegroups.com>; Mon, 19 Apr 2010 07:49:45 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.150.203.12 with HTTP; Mon, 19 Apr 2010 07:49:45 -0700 (PDT)
In-Reply-To: <59EB52DD-A958-449C-ABB4-026A19716DF9@milochik.com>
References: <59EB52DD-A958-449C-ABB4-026A19716DF9@milochik.com>
Date: Mon, 19 Apr 2010 10:49:45 -0400
Received: by 10.150.126.21 with SMTP id y21mr5930474ybc.253.1271688585480;
Mon, 19 Apr 2010 07:49:45 -0700 (PDT)
Message-ID: <o2yaf3536271004190749o4d47d297za5b83dcd9b6e74a6@mail.gmail.com>
Subject: Re: Low-Hanging Fruit
From: Karen Tracey <kmtra...@gmail.com>
To: django-developers@googlegroups.com
X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com:
domain of kmtra...@gmail.com designates 74.125.83.45 as permitted sender)
smtp.mail=kmtra...@gmail.com; dkim=pass (test mode) header...@gmail.com
X-Original-Sender: kmtra...@gmail.com
Reply-To: django-developers@googlegroups.com
Precedence: list
Mailing-list: list django-developers@googlegroups.com; contact
django-developers+owners@googlegroups.com
List-ID: <django-developers.googlegroups.com>
List-Post: <http://groups.google.com/group/django-developers/post?hl=en_US>,
<mailto:django-developers@googlegroups.com>
List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:django-developers+help@googlegroups.com>
List-Archive: <http://groups.google.com/group/django-developers?hl=en_US>
Sender: django-developers@googlegroups.com
List-Subscribe: <http://groups.google.com/group/django-developers/subscribe?hl=en_US>,
<mailto:django-developers+subscribe@googlegroups.com>
List-Unsubscribe: <http://groups.google.com/group/django-developers/subscribe?hl=en_US>,
<mailto:django-developers+unsubscribe@googlegroups.com>
Content-Type: multipart/alternative; boundary=000e0cd6a886670a5a0484981217
--000e0cd6a886670a5a0484981217
Content-Type: text/plain; charset=ISO-8859-1
On Mon, Apr 19, 2010 at 10:26 AM, Shawn Milochik <sh...@milochik.com> wrote:
> So, I'm asking for anyone in the core (or close to it) to specifically
> point out any low-hanging fruit.
Off the top of my head, a ticket I saw some activity on recently but have
not had time to look into making a test/fix for:
http://code.djangoproject.com/ticket/10523
Admin raises an exception if the repr of an object that is modified/deleted
is greater than 200 characters. Fix is probably to truncate the object's
repr to the max length of the field it's being put in. (Note this error will
only happen for DBs that actually enforce max_length -- sqlite, for example,
will happily let you store >200 chars in a field declared to only hold a max
of 200. So the test for this will only fail on current code for certain
DBs.) First place I'd likely look to put a test for this would be
regressiontests/admin_views.
Karen
--
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to django-developers+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
--000e0cd6a886670a5a0484981217
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 19, 2010 at 10:26 AM, Shawn Milochik <span dir=3D"ltr"><<a h=
ref=3D"mailto:sh...@milochik.com">sh...@milochik.com</a>></span> wrote:<=
br><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding=
-left: 1ex;">
So, I'm asking for anyone in the core (or close to it) to specifically =
point out any low-hanging fruit.</blockquote><div><br>Off the top of my hea=
d, a ticket I saw some activity on recently but have not had time to look i=
nto making a test/fix for:<br>
<br><a href=3D"http://code.djangoproject.com/ticket/10523">http://code.djan=
goproject.com/ticket/10523</a><br><br>Admin raises an exception if the repr=
of an object that is modified/deleted is greater than 200 characters. Fix =
is probably to truncate the object's repr to the max length of the fiel=
d it's being put in. (Note this error will only happen for DBs that ac=
tually enforce max_length --=20
sqlite, for example, will happily let you store >200 chars in a field
declared to only hold a max of 200. So the test for this will only fail
on current code for certain DBs.) First place I'd likely look to put a=
test for this would be regressiontests/admin_views.<br><br>Karen<br></div>=
</div><br>
<p></p>
-- <br />
You received this message because you are subscribed to the Google Groups "=
Django developers" group.<br />
To post to this group, send email to django-developers@googlegroups.com.<br=
/>
To unsubscribe from this group, send email to django-developers+unsubscribe=
@googlegroups.com.<br />
For more options, visit this group at http://groups.google.com/group/django=
-developers?hl=3Den.<br />