Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion #12074 Fixed patch and added tests.
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Alex Gaynor  
View profile  
 More options Aug 4 2010, 6:55 pm
From: Alex Gaynor <alex.gay...@gmail.com>
Date: Wed, 4 Aug 2010 18:55:36 -0400
Local: Wed, Aug 4 2010 6:55 pm
Subject: Re: #12074 Fixed patch and added tests.
On Wed, Aug 4, 2010 at 6:52 PM, David P. Novakovic

<davidnovako...@gmail.com> wrote:
> Hey, in the interest of easing myself into helping out I've picked an easy
> ticket to get done.
> http://code.djangoproject.com/ticket/12074
> I've fixed the patch and added tests.
> Let me know if I've missed something, or done something wrong :)
> Cheers,
> David

> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.

Hey David,

Thanks for contributing!  The one reccomendation I'd make is to change
the doctests into unittests.  I realize a ton of the formsets tests
are doctests, however in general we're trying to move away from them
for a number of reasons (mostly that they're a pain in the ass to
debug).  If you could switch those to be unittests I'll mark it as
RFC.

Alex

--
"I disapprove of what you say, but I will defend to the death your
right to say it." -- Voltaire
"The people's good is the highest law." -- Cicero
"Code can always be simpler than you think, but never as simple as you
want" -- Me


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.