The XMLField ticket

48 views
Skip to first unread message

Paul McMillan

unread,
Feb 26, 2011, 4:47:07 AM2/26/11
to django-d...@googlegroups.com
Ticket #3094 needs a decision.
http://code.djangoproject.com/ticket/3094#comment:17

The quick summary:

Once upon a time the XMLField accepted a schema and validated
documents against that. This hasn't been true since oldforms, yet the
documentation continues to proclaim this. Now, XMLField is basically a
TextField that takes an extra path argument. It's useless, and doesn't
validate anything.

We need to either deprecate it, provide some validation, or fix the
docs to say it doesn't do anything. We can't fix the docs till we have
a decision on this ticket.

Please weight in here or on the ticket. I'll write the patch for
whatever gets chosen.

Thanks,
-Paul

Alex Gaynor

unread,
Feb 26, 2011, 4:49:24 AM2/26/11
to django-d...@googlegroups.com

--
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-d...@googlegroups.com.
To unsubscribe from this group, send email to django-develop...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.


I'd favor having the field do nothing, emit a warning, and eventually be scrapped.  It's adding nothing ATM and no one is crying.

Alex

--
"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero

Jacob Kaplan-Moss

unread,
Feb 26, 2011, 2:31:29 PM2/26/11
to django-d...@googlegroups.com
On Sat, Feb 26, 2011 at 11:47 AM, Paul McMillan <pa...@mcmillan.ws> wrote:
> We need to either deprecate it, provide some validation, or fix the
> docs to say it doesn't do anything. We can't fix the docs till we have
> a decision on this ticket.

I say deprecate the field entirely. There isn't a good stdlib way to
validate XML (still!), so let's ditch it in favor of a 3rd party
solution.

Jacob

Russell Keith-Magee

unread,
Feb 26, 2011, 7:00:53 PM2/26/11
to django-d...@googlegroups.com

Agreed. +1.

Russ %-)

Paul McMillan

unread,
Feb 28, 2011, 3:15:09 PM2/28/11
to Django developers
I've attached a patch per the discussion here. It's ready for review
and hopefully a speedy commit.

http://code.djangoproject.com/ticket/3094#comment:19

-Paul
Reply all
Reply to author
Forward
0 new messages