What can I do to get feedback on my pull request?

76 views
Skip to first unread message

meric

unread,
Mar 25, 2013, 11:28:58 PM3/25/13
to django-d...@googlegroups.com
I have made a pull request for django 6 months ago, but it doesn't seem to be getting much response so far.

What can I do to get more feedback as to what's wrong with it, and try to get it accepted?

Here is the pull request:


Ramiro Morales

unread,
Mar 25, 2013, 11:33:14 PM3/25/13
to django-d...@googlegroups.com
Isn't it the same idea proposed (and rejected) in this thread?:

https://groups.google.com/forum/?fromgroups=#!topic/django-developers/64I3Qy4OH-A

--
Ramiro Morales
@ramiromorales

meric

unread,
Mar 25, 2013, 11:36:41 PM3/25/13
to django-d...@googlegroups.com
Thanks, I'll reply to that thread. I posted my proposal 6 months before that post, would've been nice if they posted in my thread...

Ramiro Morales

unread,
Mar 25, 2013, 11:42:11 PM3/25/13
to django-d...@googlegroups.com
On Tue, Mar 26, 2013 at 12:36 AM, meric <meri...@gmail.com> wrote:
> Thanks, I'll reply to that thread. I posted my proposal 6 months before that
> post, would've been nice if they posted in my thread...

Jacob voted in favor of the feature (on the #16774 [1]ticket) and Adrian
voted -1 on that thread. But they were unaware of the existence of the ticket.


1. https://code.djangoproject.com/ticket/16774

--
Ramiro Morales
@ramiromorales
Message has been deleted

Jacob Kaplan-Moss

unread,
Mar 26, 2013, 8:42:22 AM3/26/13
to django-developers
On Mon, Mar 25, 2013 at 10:50 PM, meric <meri...@gmail.com> wrote:
> What action, if any, do you suggest I take now?

If it's gonna get in, you/we need to talk Adrian into dropping his -1 vote.

Jacob

meric

unread,
Mar 26, 2013, 9:17:11 AM3/26/13
to django-d...@googlegroups.com
Is the 'vote' a majority or a consensus must be achieved?

Jacob Kaplan-Moss

unread,
Mar 26, 2013, 9:36:59 AM3/26/13
to django-developers
Adrian's one of the BDFLs (I'm the other), so if he says "no" that stands.

Usually, we operate the way most open source projects do: "rough
consensus and working code". You've got the second ("working code") so
you need to work on the first, I think. Usually a strong consensus is
enough to override a committer's veto, even a BDFL veto, so if you can
show that this is a strong enough need, Adrian might drop his veto.

[For more on how we make decisions, see
https://docs.djangoproject.com/en/1.5/internals/contributing/bugs-and-features/#how-we-make-decisions]

Of course, I'm putting words in Adrian mouth, so this is all just a
guess. It's possible that he's really against this, in which case
you're basically SOL.

Adrian, if you're still following this thread... maybe want to weigh
in on how we might convince you to drop that veto?

Jacob

On Tue, Mar 26, 2013 at 8:17 AM, meric <meri...@gmail.com> wrote:
> Is the 'vote' a majority or a consensus must be achieved?
>
> --
> You received this message because you are subscribed to the Google Groups "Django developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
> To post to this group, send email to django-d...@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-developers?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Reply all
Reply to author
Forward
0 new messages