newforms-admin Status Update
Brian Rosner
I wanted to quickly update everyone on the status of the
newforms-admin branch. It is quite literally a few tickets away! I
have either fixed or triaged many tickets today so that the branch can
get merged into trunk. The tickets triaged really shouldn't have been
made blocker tickets and since we are rapidly approaching the 1.0
alpha they can be looked at after the merge to trunk.
There are couple of tickets I want to get some opinions on.
#5490 [1] - The patch has been marked ready for check-in, but to me
something doesn't feel right with the patch. The patch introduces
URL_SAFE_CHARACTERS in django.utils.http and is used in the admin by
passing it in as the safe keyword argument to urlquote. Wouldn't it
seem reasonable to just make it the default value of safe?
#5780 [2] - Honza and Joseph have been looking at this. While this
seems reasonable, it seems to involve a lot more than just what the
patch does. Ideally all the save functionality is refactored in
ModelAdmin a bit to allow for commit=False behavior. Should this still
be considered a nfa-blocker?
#7353 [3] - I am not exactly sure what this ticket is trying to say
that is wrong with newforms-admin? AddManipulator no longer exists as
functionality code with the branch. Could someone give a bit more
information to get this fixed or just close it.
Other than those, I have the remaining tickets as WIP locally. They
will be finished tomorrow.
The documentation is pretty much done. I would like for people to give
it some attention and shake out any problems. Not a big deal and can
be dealt with after a merge. The tutorial needs a bit of
newforms-admin love. I haven't touched it due to the sensitivity of it
so if Adrian or Jacob can take a whip at that that would be great!
The branch has seen a lot of usage and I don't think it needs a call
for testing, but for those who would like to test it now is that time.
Please bang on it and report bugs in Trac.
[1]: http://code.djangoproject.com/ticket/5490
[2]: http://code.djangoproject.com/ticket/5780
[3]: http://code.djangoproject.com/ticket/7353
Thanks,
Brian Rosner
http://oebfare.com
Joseph Kocherhans
>
> Hey all,
>
> I wanted to quickly update everyone on the status of the
> newforms-admin branch. It is quite literally a few tickets away! I
> have either fixed or triaged many tickets today so that the branch can
> get merged into trunk. The tickets triaged really shouldn't have been
> made blocker tickets and since we are rapidly approaching the 1.0
> alpha they can be looked at after the merge to trunk.
Woo hoo! Thank you for all your work on this.
> #5780 [2] - Honza and Joseph have been looking at this. While this
> seems reasonable, it seems to involve a lot more than just what the
> patch does. Ideally all the save functionality is refactored in
> ModelAdmin a bit to allow for commit=False behavior. Should this still
> be considered a nfa-blocker?
I don't think this is a blocker either, but it's certainly a pre-1.0
thing that should go together with #6406 and #6002 which you
(rightfully) moved off of the blocker list a little while ago. I
looked at all of those last night and have some ideas, but it's
tricky. They *will* introduce some API changes, but I don't see any
reason why all API changes need to happen on the branch. To be more
specific, those changes will be limited to people overriding
ModelAdmin... not for people just casually using the admin system.
Likely, some hooks will go away, some signatures will be changed, and
more hooks will be added.
> #7353 [3] - I am not exactly sure what this ticket is trying to say
> that is wrong with newforms-admin? AddManipulator no longer exists as
> functionality code with the branch. Could someone give a bit more
> information to get this fixed or just close it.
Hopefully James will comment on this. I don't see how it could be a
problem for newforms-admin anymore.
Joseph
alex....@gmail.com
error with oldforms-admin, and once upgrading to newforms-admin it was
resolved.
On Jul 16, 12:16 am, "Joseph Kocherhans" <jkocherh...@gmail.com>
wrote:
Brian Rosner
On Jul 15, 2008, at 10:50 PM, Brian Rosner wrote:
> The documentation is pretty much done. I would like for people to give
> it some attention and shake out any problems. Not a big deal and can
> be dealt with after a merge. The tutorial needs a bit of
> newforms-admin love. I haven't touched it due to the sensitivity of it
> so if Adrian or Jacob can take a whip at that that would be great!
>
I have created a ticket [1] for this.
[1]: http://code.djangoproject.com/ticket/7787
Brian Rosner
http://oebfare.com