[newforms-admin] edit_inline support for generic relations

2 views
Skip to first unread message

Honza Král

unread,
Jun 23, 2007, 1:04:45 PM6/23/07
to django-d...@googlegroups.com
Hi,
I hacked together a patch implementing edit_inline functionality for
newforms-admin. Since I had to make some changes to the original
edit_inline code, I would like some feedback from the devs.

The ticket is http://code.djangoproject.com/ticket/4667

* InlineFormset.rel_name is not really applicable in this case,
what would be best to use as a prefix (the value in the patch - 'aaa'
is far from ideal ;) )

* I moved some of the functionality to FormSet (add_fk), to allow
for custom binding between objects and use string
"content_type_field:object_id_field" as the foreign key name to pass
that information. I feel that its not the most elegant solution, could
anybody help me out here with some ideas? thanks


After I work these questions out, I will clean up the patch.

btw. Great work, Joseph Kocherhans, your implementation of edit_inline
really made this easy for me, thanks.

--
Honza Král
E-Mail: Honza...@gmail.com
ICQ#: 107471613
Phone: +420 606 678585

wnielson

unread,
Jun 26, 2007, 1:37:37 PM6/26/07
to Django developers
Excellent! I also need this sort of functionality. I'm going to try
it out now and I'll give you what feedback I can.

-Weston

Reply all
Reply to author
Forward
0 new messages