Thanks for the pointer; I'd agree this should get in.
Jacob
There has been much reluctancy in letting triagers tag and prioritize
1.0.1 milestone tickets. Now that 1.0.1 is really close, can we
perhaps discuss what are the things that really should be fixed before
it is released?
The only major issue I have encountered is http://code.djangoproject.com/ticket/8882
that makes inline formsets that have unique fields (that is, pretty
much every other use case for them) unusable. Looks like brosner is
already working on it -- thanks! -- and it would be perhaps wasteful
if 1.0.1 is released before he has finished.
We certainly can discuss such things. To open a discussion on a
particular ticket, post a working patch with unit tests.
--
"Bureaucrat Conrad, you are technically correct -- the best kind of correct."
regards
Steve
#8898 and #9482 are both simple bug fixes with patches that remain
unreviewed. #9214 is a simple backwards compatible enhancement with
patch.
I'm reluctant to mark them "ready for checkin" as I am the reporter,
but it's been 1-2 months for some of these with no review from
anybody, and at least the first two are very simple fixes for bugs
with no change in functionality.
How should one get attention for these tickets?
http://code.djangoproject.com/ticket/8898
http://code.djangoproject.com/ticket/9482
http://code.djangoproject.com/ticket/9214
You do know that Karen has a commit bit, right? If she's got concerns
about a ticket, then I at least take that as meaning it's got problems
and isn't ready for checkin.
I've put this ticket back to "accepted" as per your comment that the
bug should be fixed. As you say, the DDN and confused comments were
not intended to raise a red flag, and should have been taken to a
separate ticket. The suggested change would have been backwards
incompatible, anyway. IMHO, the bug should be fixed as it is,
regardless of any possible future changes.
There's still no comment in the ticket from a core developer or
anybody else, though. As this is a simple bug fix, can I (as the
reporter) mark this ready for checkin, as there is a patch with tests?
...
Famous last words, indeed. Can you see any way that setting
DJANGO_SETTINGS_MODULE *before* importing the project module could
break existing code? Wouldn't that mean that manually setting
DJANGO_SETTINGS_MODULE before calling any management commands would
also be broken? :)
> On a somewhat related note, is there some reason that 1.0.1 and 1.1
> milestones have not been created in Trac? It seems like triaging bugs
> into one of these releases should happen in Trac, not the mailing
> list.
Yes, there is a reason, and it has been given several times in recent
history. The v1.0.1 milestone has not bee created in Trac because it
will not in any way help us deliver the v1.0.1 release. There is no
difference between the "list of all bugs' and the "list of bugs that
we want to close for v1.0.1". We may not be successful in meeting this
goal, but that doesn't change the underlying goal.
In understand that twiddling milestone flags on tickets apparently
gives some people the warm, satisfying feeling that they are helping.
However, speaking as one of the core developers, it would be much more
helpful for that effort to be directed towards actually triaging new
tickets (validating that a bug exists, finding duplicates, correctly
classifying tickets etc), writing patches, and testing those patches.
These are the jobs that are hard to do, and aren't assisted by having
a new milestone flag to fiddle with in Trac.
The 1.1 milestone doesn't exist because we haven't decided what will
be in v1.1 yet. Once the discussion period is over (in a week or so),
the milestone will be opened, and tickets will be assigned.
Yours,
Russ Magee %-)
And if you feel that's the case, by all means bring them up. But there
isn't any special bit in Trac to set for it, and there's really no
great need for such a thing. So let it go, OK?
--
"Bureaucrat Conrad, you are technically correct -- the best kind of correct."
"Most other projects" is an ad hominem, so I won't respond to that.
Let me lay out the alternatives to you. Let us assume that we have a
milestone, and tickets get assigned to it:
Option 1: We don't release until all tickets on the milestone are complete.
Option 2: We release on a date, with as many bug fixes as we can manage.
I can guarantee you that Option 1 will result in a release that is
later than expected, for any value of "expected". The amount of time
available for development to the core team is not a constant, nor is
it particularly predictable. We (the core developers) wore a lot of
flack for waiting too long between 0.96 and 1.0. If we end up delaying
v1.0.1 so we can meet a milestone list, mark my words - there will be
a cry of "Why not just release a v1.0.0.1 with the interim fixes".
Option 2 gives us timely releases, each of which is better than the
last (i.e., less bugs). However, this doesn't require a milestone tag
- all bugs are targets, and the general level of noise on the mailing
list helps to prioritize the bugs that require immediate attention.
For example, the inline problems you mentioned, and the URL reversal
problems that were resolved early in the v1.0.X process were both
significant bugs. The decision to fix these was made without the need
for a milestone tag.
Yes - we set a milestone for v1.0, but that is a bad example of how
(and why) milestones work. The fact that a milestone worked for the
version 1.0 release is due to two extraordinary factors:
1) The mystique surrounding Version One ensured more attention than
normal from the core developers
2) Malcolm and Jacob just about killed themselves in the last few
weeks with the amount of effort they put in to make sure the 1.0
milestone list was complete.
I wouldn't base any planning process on the assumption that either of
these are guaranteed to happen again.
On top of that, we (the core developers) committed ourself to
backwards compatibility at the v1.0 release, and we had a lot of
little things that needed to be cleaned up before we made that
commitment. A milestone is a very convenient way to keep track of the
subset of issues that stood in the way of that goal.
Post v1.0, our only goal is "zarro boogs", delivered on a timely
schedule - again, we don't need milestones to keep track of this goal,
because every open ticket is a target. What we _do_ need is a
community that works on triage and bug fixes, and draws the attention
of the core devs to particularly annoying or confusing bugs.
Yours,
Russ Magee %-)
Notice how I have not only marked the issue accepted, but I assigned
it to myself. I would think that is a decent indication that this is a
serious issue considering things are broken and that it will make the
release :)
--
Brian Rosner
http://oebfare.com