Bug introduced at changeset 4500

1 view
Skip to first unread message

Rudolph

unread,
Feb 15, 2007, 9:02:12 AM2/15/07
to Django developers
Hi,

I think I found a bug introduced in changeset 4500 (http://
code.djangoproject.com/changeset/4500). When a min_num_in_admin is
specified without a num_in_admin, the "add" view in the admin
interface gives an exception (and possibly the change view as wel, I
didn't test that). Does anyone else experience this since changeset
4500?

Rudolph

Malcolm Tredinnick

unread,
Feb 15, 2007, 4:53:21 PM2/15/07
to django-d...@googlegroups.com

I did some testing before committing that change, but I may have missed
this case. I'll have a look at it when I get a chance this morning and
fix it if I can track down the problem.

Thanks for the heads-up and apologies for costing you some time.

Regards,
Malcolm


Rudolph

unread,
Feb 17, 2007, 3:14:47 AM2/17/07
to Django developers
On Feb 15, 10:53 pm, Malcolm Tredinnick <malc...@pointy-stick.com>
wrote:

No apologies needed, it's the trunk version after all. Thanks in
advance for your time to correct it.

Rudolph

Malcolm Tredinnick

unread,
Feb 18, 2007, 11:20:16 PM2/18/07
to django-d...@googlegroups.com
On Thu, 2007-02-15 at 06:02 -0800, Rudolph wrote:

After a fair bit of head scratching and chasing code paths, I think I
managed to fix this in the correct way. The update is in revision r4542.
The problem hadn't ever shown up before because we weren't correctly
handling min_num_in_admin > num_in_admin cases prior to r4500.

Regards,
Malcolm


Rudolph

unread,
Feb 19, 2007, 3:21:09 AM2/19/07
to Django developers
On Feb 19, 5:20 am, Malcolm Tredinnick <malc...@pointy-stick.com>
wrote:

> After a fair bit of head scratching and chasing code paths, I think I
> managed to fix this in the correct way. The update is in revision r4542.
> The problem hadn't ever shown up before because we weren't correctly
> handling min_num_in_admin > num_in_admin cases prior to r4500.
>
> Regards,
> Malcolm

Thanks, I'll test my problem and let you know the result.

Regards,

Rudolph

Reply all
Reply to author
Forward
0 new messages