be localflavor Belgium

[Laurent Luce]

Hello,

I created a patch to add support for Belgium to localflavor. I
attached the patch to a ticket which is marked as accepted. The patch
contains the forms fields, unit tests and the doc changes.

What do I need to do next ? Wait for someone to review the patch and
commit it ?

Laurent

[Gert Van Gool]

IMHO I would allow a non-spaced version. My typing my phone number as 0498725202 should also work.

Second thing, wrap the long lines :)

Relevant ticket is #14349 (http://code.djangoproject.com/ticket/14349)

-- Gert

Mobile: +32 498725202

Twitter: @gvangool
Web: http://gert.selentic.net

--
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-d...@googlegroups.com.
To unsubscribe from this group, send email to django-develop...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.

[Laurent Luce]

I added a new patch to the ticket with the following changes:
add support for 0xxxxxxxx, 04xxxxxxxx phone number format. Wrap long
lines.

Laurent

On Sep 29, 11:23 am, Gert Van Gool <gertvang...@gmail.com> wrote:
> IMHO I would allow a non-spaced version. My typing my phone number as
> 0498725202 should also work.
> Second thing, wrap the long lines :)
>
> Relevant ticket is #14349 (http://code.djangoproject.com/ticket/14349)
>
> -- Gert
>
> Mobile: +32 498725202

> Twitter: @gvangool <http://twitter.com/gvangool>
> Web:http://gert.selentic.net

>
> On Wed, Sep 29, 2010 at 18:26, Laurent Luce <laurentluc...@yahoo.com> wrote:
> > Hello,
>
> > I created a patch to add support for Belgium to localflavor. I
> > attached the patch to a ticket which is marked as accepted. The patch
> > contains the forms fields, unit tests and the doc changes.
>
> > What do I need to do next ? Wait for someone to review the patch and
> > commit it ?
>
> > Laurent
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Django developers" group.
> > To post to this group, send email to django-d...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > django-develop...@googlegroups.com<django-developers%2Bunsu...@googlegroups.com>
> > .

[Laurent Luce]

I updated the be localflavor patch to use unit tests instead of
doctests as requested. Can you check if this is what you want. There
was no unit tests in regressiontests/forms/localflavor/ so I am not
100% sure I did what is expected. I took a look at the ones in
regressiontests/forms as models.

[Russell Keith-Magee]

On Fri, Oct 1, 2010 at 6:15 AM, Laurent Luce <lauren...@yahoo.com> wrote:
> I updated the be localflavor patch to use unit tests instead of
> doctests as requested. Can you check if this is what you want. There
> was no unit tests in regressiontests/forms/localflavor/ so I am not
> 100% sure I did what is expected. I took a look at the ones in
> regressiontests/forms as models.

The patch looks good, so I've just bumped the ticket to ready for checkin.

Thanks for the contribution!

Yours,
Russ Magee %-)

[Laurent Luce]

Am I supposed to commit the patch? I don't think I have the privileges
to do that.

Laurent

On Sep 30, 5:35 pm, Russell Keith-Magee <russ...@keith-magee.com>
wrote:

[Łukasz Rekucki]

On 3 October 2010 20:53, Laurent Luce <lauren...@yahoo.com> wrote:
> Am I supposed to commit the patch? I don't think I have the privileges
> to do that.

No, only core developers can commit changes. The patch is marked RFC
and has milestone 1.3, so it's pretty sure it won't be forgotten. I
suspect that because Russel reviewed the patch, some other core
developer needs to commit it (but that's just a wild guess). So sit
back, relax and send a friendly reminder some time before feature
freeze on October 18[1].

[1]: http://www.djangoproject.com/weblog/2010/sep/30/django-1_3-release-schedule/

--
Łukasz Rekucki

[Russell Keith-Magee]

2010/10/4 Łukasz Rekucki <lrek...@gmail.com>:

> On 3 October 2010 20:53, Laurent Luce <lauren...@yahoo.com> wrote:
>> Am I supposed to commit the patch? I don't think I have the privileges
>> to do that.
>
> No, only core developers can commit changes. The patch is marked RFC
> and has milestone 1.3, so it's pretty sure it won't be forgotten. I
> suspect that because Russel reviewed the patch, some other core
> developer needs to commit it (but that's just a wild guess). So sit
> back, relax and send a friendly reminder some time before feature
> freeze on October 18[1].

No - I'll commit it when I have the time. It's just that we're
focusing on major features right now, so minor feature additions are
taking a back seat.

Once October 18th and the feature freeze hits, I wlll commit -- or
another core developer will if they beat me to it.

So - Laurent - you've done everything right (and thanks for the
patch); in a couple of weeks your code should be in trunk.

Yours,
Russ Magee %-)