middleware exception catching for core handlers

[Gary Wilson Jr.]

We don't seem to be catching exceptions raised in response or request
middleware, causing bare exceptions to be displayed. Is there a reason
we are not catching these and displaying pretty error pages?

Which leads me to another observation. There seems to be a bit of
duplication in the WSGIHandler/ModPythonHandler and
WSGIRequest/ModPythonRequest classes.

Gary

[Brian Harring]

Resurrecting this email, anyone got a valid reason for not
intercepting these exceptions?

I know I got a nasty surprise when I noticed it in my apache logs.

~brian

[Karen Tracey]

Can't answer as to why it is the way it is, but Gary did open a defect to track the issue, and it has a patch:

http://code.djangoproject.com/ticket/6094

Someone else a couple of weeks ago opened another couple of defects covering the same issue, and when pointed to the first defect updated the patch to apply cleanly against (then-current) trunk.  So there's a patch to try and report results of, if you like.  No one has piped up to say why this shouldn't be changed, so I'd guess it's just waiting on someone with enough expertise and time to give it some attention.

Karen

[Malcolm Tredinnick]

I'm looking at this at the moment. Something will be in later today.

Malcolm

>
--
If you think nobody cares, try missing a couple of payments.
http://www.pointy-stick.com/blog/

[Gary Wilson Jr.]

Karen Tracey wrote:
> Can't answer as to why it is the way it is, but Gary did open a defect to
> track the issue, and it has a patch:
>
> http://code.djangoproject.com/ticket/6094
>
> Someone else a couple of weeks ago opened another couple of defects covering
> the same issue, and when pointed to the first defect updated the patch to
> apply cleanly against (then-current) trunk. So there's a patch to try and
> report results of, if you like. No one has piped up to say why this
> shouldn't be changed, so I'd guess it's just waiting on someone with enough
> expertise and time to give it some attention.

I was mainly waiting for review and some testing. Malcolm has now reviewed
it. I have not tested it in a ModPython setup yet. So please, test and note
your results here. I've just added an updated patch to the ticket, enjoy.

Gary