Reopening/Refixing #20246

[Florian Apolloner]

Hi,

I don't think that the fix of #20246 [0] is correct. You started using \xa0 while Wikipedia clearly suggests that we should use a narrow space instead of a full-space (probably U+202F). This is something we learned during our physics courses too, so it's in line with what science departments do too.

Any objections on refixing it?

Cheers,
Florian

0: https://code.djangoproject.com/ticket/20246

[Claude Paroz]

Hi Florian,

I'm not completely sure. The narrow space should certainly be used between a number and its unit symbol (kg, cm, Mb, etc.). So your proposal is at least valid for a part of the patch. However, for "5 hours, 4 minutes", I'm not sure it's the same rule. I'd suggest you add references on the ticket and then fix the parts that need to be fixed.

Claude

[Florian Apolloner]

Hi,

On Sunday, May 19, 2013 8:18:48 PM UTC+2, Claude Paroz wrote:

I'm not completely sure. The narrow space should certainly be used between a number and its unit symbol (kg, cm, Mb, etc.). So your proposal is at least valid for a part of the patch. However, for "5 hours, 4 minutes", I'm not sure it's the same rule. I'd suggest you add references on the ticket and then fix the parts that need to be fixed.

Hmm, how do you suggest fixing it? adding a new function avoid_narrow_wrapping and changing everything in defaultfilters, or… (I am asking cause the current fix confuses me, since you didn't touch the translations [eg https://github.com/django/django/commit/7d77e9786a118dd95a268872dd9d36664066b96a#L3R825 ] but just replace the space later on).

Thanks,
Florian

[Claude Paroz]

Let's continue the discussion on the ticket. But basically, I would add
an optional parameter to avoid_wrapping to be able to specify the
separator character.

Claude

--
www.2xlibre.net