Changeset 7427

1 view
Skip to first unread message

Ivan Illarionov

unread,
Apr 19, 2008, 11:50:30 AM4/19/08
to Django developers
I can't test it but I bet something is wrong with changeset 7427.
AFAIK query_class method should create the OracleQuery class as
subclass of DefaultQueryClass and return this new class with correct
backend-specific resolve_columns and as_sql methods. But it does
something strange here.

I bet Oracle is broken in qs-rf.

Hope this helps.


Regards,
Ivan Illarionov

Justin Bronn

unread,
Apr 20, 2008, 12:39:38 AM4/20/08
to Django developers
> I bet Oracle is broken in qs-rf.

Yeah, Malcolm opened up #7036 two days ago in response to errors
reported by Ian Kelly. I've attached a patch.

The problem had to do with `resolve_columns` not taking into account
that extra select SQL is in a different position due to changes in
#7340. The extra select SQL is needed for the hack that simulates
LIMIT and OFFSET under Oracle.

-Justin
Reply all
Reply to author
Forward
0 new messages