newforms SortedDictFromList needed still?
SmileyChris
Do we still need django.newforms.forms::SortedDictFromList?
The only thing which the newforms code has extra is its own copy
function which uses deepcopy. I'm at a loss to see why we're using it
there and not on the main SortedDict copy method.
Gary Wilson
> [6506] fixed #5744.
>
> Do we still need django.newforms.forms::SortedDictFromList?
Nice catch, it indeed looks like SortedDictFromList is no longer needed.
> The only thing which the newforms code has extra is its own copy
> function which uses deepcopy. I'm at a loss to see why we're using it
> there and not on the main SortedDict copy method.
Speaking of, is there a reason we are using deepcopy in copy()? Isn't copy
supposed to only create a shallow copy?
Perhaps we need to turn that into a __deepcopy__ method and change the places
in the code that are expecting copy() to return a deepcopy.
Gary