WebRTC in WebKit and ICE/TURN implementation status

[Kaiduan Xie]

Hi,

Had Google contributed WebRTC source code to WebKit? If yes, where is
the code path in WebKit? Does it have the functionality covered in
PeerConnection00 specification? Does Google keep the code of WebRTC in
WebKit synchronized with the Google internal implementation on daily
basis? If no, how frequently Google contribute the internal
implementation back to WebKit?

As far as I know from this mail list, Google WebRTC ICE/TURN
implementation does not closely follow rfc 5245 (ICE) and rfc 5766
(TURN), and Google is working on it, can Google provide update on
this? How close it is to finish?

Thanks a lot for help,

/Kaiduan

[Vikas]

On Aug 29, 11:28 am, Kaiduan Xie <kaidu...@gmail.com> wrote:
> Hi,
>
> Had Google contributed WebRTC source code to WebKit? If yes, where is
> the code path in WebKit? Does it have the functionality covered in
> PeerConnection00 specification? Does Google keep the code of WebRTC in
> WebKit synchronized with the Google internal implementation on daily
> basis? If no, how frequently Google contribute the internal
> implementation back to WebKit?

Yes we have WebRTC source code in WebKit. You can goto https://trac.webkit.org/
and search for PeerConnection. It does include PeerConnection00
specification. We do try to keep the code synchronized.

> As far as I know from this mail list, Google WebRTC ICE/TURN
> implementation does not closely follow rfc 5245 (ICE) and rfc 5766
> (TURN), and Google is working on it,  can Google provide update on
> this? How close it is to finish?

That is correct, we are currently working on it and it will be out
soon.

[Kaiduan Xie]

Thank you Vikas for the response.

However, I am puzzled by the following finding,

https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/PeerConnection00.h

OwnPtr<PeerConnection00Handler> m_peerHandler;

https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp

Here all operations are redirected to PeerConnection00Handler.

However,

https://trac.webkit.org/browser/trunk/Source/WebCore/platform/mediastream/PeerConnection00Handler.h
https://trac.webkit.org/browser/trunk/Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp

// Dummy implementations below for ports that build with MEDIA_STREAM
enabled by default.

All the function in the PeerConnection00Handler are dummy.

Did I follow the right path?

Also I did not find the libjingle/STUN/ICE code in WebKit source, are
they in different repository?

Thanks,

/Kaiduan

> --
>
>
>

[Tommy Widenflycht (ᛏᚮᛘᛘᚤ)]

See inline for answers but first a short comment regarding webkit: We (aka Google) does not have an internal repository for WebKit, what you see on WebKit.org is what we have.

On Thu, Aug 30, 2012 at 4:20 AM, Kaiduan Xie <kaid...@gmail.com> wrote:

Thank you Vikas for the response.

However, I am puzzled by the following finding,

https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/PeerConnection00.h

            OwnPtr<PeerConnection00Handler> m_peerHandler;

https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp

Here all operations are redirected to PeerConnection00Handler.

However,

https://trac.webkit.org/browser/trunk/Source/WebCore/platform/mediastream/PeerConnection00Handler.h
https://trac.webkit.org/browser/trunk/Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp

// Dummy implementations below for ports that build with MEDIA_STREAM
enabled by default.

All the function in the PeerConnection00Handler are dummy.

Did I follow the right path?

No, you should look here instead:

https://trac.webkit.org/browser/trunk/Source/WebCore/platform/mediastream/chromium/PeerConnection00Handler.cpp

 

Also I did not find the libjingle/STUN/ICE code in WebKit source, are
they in different repository?

WebKit does not know anything about network protocols etc, that code comes from webrtc.org in chromium.

Thanks,

/Kaiduan

On Wed, Aug 29, 2012 at 6:43 PM, Vikas <vikasm...@webrtc.org> wrote:
>
>
> On Aug 29, 11:28 am, Kaiduan Xie <kaidu...@gmail.com> wrote:
>> Hi,
>>
>> Had Google contributed WebRTC source code to WebKit? If yes, where is
>> the code path in WebKit? Does it have the functionality covered in
>> PeerConnection00 specification? Does Google keep the code of WebRTC in
>> WebKit synchronized with the Google internal implementation on daily
>> basis? If no, how frequently Google contribute the internal
>> implementation back to WebKit?
>
> Yes we have WebRTC source code in WebKit. You can goto https://trac.webkit.org/
> and search for PeerConnection. It does include PeerConnection00
> specification. We do try to keep the code synchronized.
>
>> As far as I know from this mail list, Google WebRTC ICE/TURN
>> implementation does not closely follow rfc 5245 (ICE) and rfc 5766
>> (TURN), and Google is working on it,  can Google provide update on
>> this? How close it is to finish?
>
> That is correct, we are currently working on it and it will be out
> soon.
>
>> Thanks a lot for help,
>>
>> /Kaiduan
>
> --
>
>
>

--

--

Tommy Widenflycht | Senior Software Engineer | tom...@google.com | +46 734162531

Google Sweden AB, Kungsbron 2, SE-11122 Stockholm, Sweden
Org. nr. 556656-6880