0.4.2 web interface version incorrect

33 views
Skip to first unread message

Ryan Nowakowski

unread,
May 16, 2012, 10:01:48 PM5/16/12
to disc...@googlegroups.com
I've upgrade to 0.4.2 by building my own debian packages. The version
number at the bottom of the web interface says: Disco 0.4.1-226-g4f2eeb2

I grepped through my build and disco.app has the incorrect version in
it:

ry...@ec2-e-01.wopr:~/build/disco [0.4.2-bigfoot1]$ grep -r g4f2eeb2 .
./master/ebin/disco.app: {vsn,"0.4.1-226-g4f2eeb2"},
./pkg/debian/disco-node/usr/lib/disco/master/ebin/disco.app: {vsn,"0.4.1-226-g4f2eeb2"},
ry...@ec2-e-01.wopr:~/build/disco [0.4.2-bigfoot1]$

Any idea where that old version number is coming from?

Prashanth Mundkur

unread,
May 17, 2012, 2:24:30 AM5/17/12
to disc...@googlegroups.com
Did you try 'make clean' before building your package?

--
prashanth

Ryan Nowakowski

unread,
May 17, 2012, 10:32:26 AM5/17/12
to disc...@googlegroups.com
Yes, I ran both "make clean" and "cd pkg/debian; make clean".

Ryan Nowakowski

unread,
May 17, 2012, 12:10:56 PM5/17/12
to disc...@googlegroups.com
Here's a log of a clean build from github master.  You can see the older "g4f2eeb2" is in disco.app after the make.

 ry...@ec2-e-01.wopr:~/sandboxes$ git clone https://github.com/discoproject/disco.git
Cloning into disco...
remote: Counting objects: 16723, done.
remote: Compressing objects: 100% (5713/5713), done.
remote: Total 16723 (delta 10897), reused 16567 (delta 10764)
Receiving objects: 100% (16723/16723), 4.78 MiB, done.
Resolving deltas: 100% (10897/10897), done.
ry...@ec2-e-01.wopr:~/sandboxes$ cd disco/
ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$ grep -r g4f2eeb2 .
ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$ make
==> master (get-deps)
Pulling lager from {git,"git://github.com/basho/lager.git",{tag,"1.0.0"}}
Cloning into lager...
Pulling mochiweb from {git,"https://github.com/discoproject/mochiweb.git",
                           {branch,"implement-max-conns"}}
Cloning into mochiweb...
==> lager (get-deps)
==> mochiweb (get-deps)
==> lager (compile)
Compiled src/lager_util.erl
Compiled src/lager_transform.erl
Compiled src/lager_sup.erl
Compiled src/lager_app.erl
Compiled src/lager_console_backend.erl
Compiled src/lager_trunc_io.erl
Compiled src/lager_handler_watcher_sup.erl
Compiled src/lager_stdlib.erl
Compiled src/lager.erl
Compiled src/lager_format.erl
Compiled src/error_logger_lager_h.erl
Compiled src/lager_file_backend.erl
Compiled src/lager_handler_watcher.erl
Compiled src/lager_mochiglobal.erl
Compiled src/lager_crash_log.erl
==> mochiweb (compile)
Compiled src/mochiglobal.erl
Compiled src/mochiweb_socket.erl
Compiled src/mochitemp.erl
Compiled src/mochiweb_response.erl
Compiled src/mochiweb_multipart.erl
Compiled src/mochiweb_socket_server.erl
Compiled src/mochinum.erl
Compiled src/mochijson.erl
Compiled src/mochiweb_request_tests.erl
Compiled src/reloader.erl
Compiled src/mochiweb.erl
Compiled src/mochifmt.erl
Compiled src/mochiweb_io.erl
Compiled src/mochiweb_http.erl
Compiled src/mochiweb_request.erl
Compiled src/mochihex.erl
Compiled src/mochiweb_cover.erl
Compiled src/mochiweb_cookies.erl
Compiled src/mochiweb_socket_server_tests.erl
Compiled src/mochiweb_echo.erl
Compiled src/mochilists.erl
Compiled src/mochilogfile2.erl
Compiled src/mochifmt_std.erl
Compiled src/mochiutf8.erl
Compiled src/mochiweb_util.erl
Compiled src/mochiweb_mime.erl
Compiled src/mochifmt_records.erl
Compiled src/mochiweb_headers.erl
Compiled src/mochiweb_acceptor.erl
Compiled src/mochiweb_html.erl
Compiled src/mochijson2.erl
Compiled src/mochiweb_charref.erl
==> master (compile)
Compiled src/node_mon.erl
Compiled src/event_server.erl
Compiled src/fair_scheduler_fair_policy.erl
Compiled src/worker_runtime.erl
Compiled src/fair_scheduler_job.erl
Compiled src/worker_protocol.erl
Compiled src/work_queue.erl
Compiled src/web_server.erl
Compiled src/lock_server.erl
Compiled src/disco.erl
Compiled src/disco_main.erl
Compiled src/worker_inputs.erl
Compiled src/worker_throttle.erl
Compiled src/disco_server.erl
Compiled src/job_coordinator.erl
Compiled src/netstring.erl
Compiled src/disco_proxy.erl
Compiled src/disco_util.erl
Compiled src/ddfs/ddfs_web.erl
Compiled src/disco_web.erl
Compiled src/ddfs/ddfs_node.erl
Compiled src/ddfs/http_queue.erl
Compiled src/ddfs/ddfs_gc_node.erl
Compiled src/ddfs/ddfs_put.erl
Compiled src/ddfs/ddfs_tag_util.erl
Compiled src/ddfs/ddfs_gc.erl
Compiled src/discozip.erl
Compiled src/ddfs/ddfs_get.erl
Compiled src/ddfs/ddfs_master.erl
Compiled src/ddfs/ddfs_util.erl
Compiled src/ddfs/ddfs_gc_main.erl
Compiled src/ddfs/ddfs_http.erl
Compiled src/ddfs/ddfs_tag.erl
Compiled src/ddfs/ddfs.erl
Compiled src/json_validator.erl
Compiled src/temp_gc.erl
Compiled src/trunc_io.erl
Compiled src/fair_scheduler_fifo_policy.erl
Compiled src/shuffle.erl
Compiled src/disco_config.erl
Compiled src/disco_worker.erl
Compiled src/jobpack.erl
Compiled src/fair_scheduler.erl
ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$ grep -r g4f2eeb2 .
./master/ebin/disco.app:              {vsn,"0.4.1-226-g4f2eeb2"},
ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$

Ryan Nowakowski

unread,
May 17, 2012, 12:26:32 PM5/17/12
to disc...@googlegroups.com
It seems to be an issue with the way rebar handles {vsn, git} in app.src files.  Even though "git describe" returns 0.4.2, rebar still uses 0.4.1 as it's git version.

 ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ git describe 
0.4.2-4-gea5300d
ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ grep -r g4f2eeb2 .
ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ ./rebar compile
==> lager (compile)
Compiled src/lager_util.erl
Compiled src/lager_transform.erl
Compiled src/lager_sup.erl
Compiled src/lager_app.erl
Compiled src/lager_console_backend.erl
Compiled src/lager_trunc_io.erl
Compiled src/lager_handler_watcher_sup.erl
Compiled src/lager_file_backend.erl
Compiled src/lager.erl
Compiled src/lager_stdlib.erl
Compiled src/lager_format.erl
Compiled src/error_logger_lager_h.erl
Compiled src/lager_handler_watcher.erl
Compiled src/lager_mochiglobal.erl
Compiled src/lager_crash_log.erl
==> mochiweb (compile)
Compiled src/mochiglobal.erl
Compiled src/mochiweb_socket.erl
Compiled src/mochiweb_multipart.erl
Compiled src/mochiweb_response.erl
Compiled src/mochitemp.erl
Compiled src/mochiweb_socket_server.erl
Compiled src/reloader.erl
Compiled src/mochinum.erl
Compiled src/mochijson.erl
Compiled src/mochiweb_request_tests.erl
Compiled src/mochiweb.erl
Compiled src/mochifmt.erl
Compiled src/mochiweb_io.erl
Compiled src/mochiweb_http.erl
Compiled src/mochihex.erl
Compiled src/mochiweb_request.erl
Compiled src/mochiweb_util.erl
Compiled src/mochiweb_cover.erl
Compiled src/mochilists.erl
Compiled src/mochiweb_socket_server_tests.erl
Compiled src/mochiweb_echo.erl
Compiled src/mochiweb_cookies.erl
Compiled src/mochilogfile2.erl
Compiled src/mochifmt_std.erl
Compiled src/mochiutf8.erl
Compiled src/mochiweb_headers.erl
Compiled src/mochiweb_mime.erl
Compiled src/mochifmt_records.erl
Compiled src/mochiweb_acceptor.erl
Compiled src/mochijson2.erl
Compiled src/mochiweb_html.erl
Compiled src/mochiweb_charref.erl
==> master (compile)
Compiled src/node_mon.erl
Compiled src/fair_scheduler_fair_policy.erl
Compiled src/worker_runtime.erl
Compiled src/event_server.erl
Compiled src/worker_protocol.erl
Compiled src/fair_scheduler_job.erl
Compiled src/web_server.erl
Compiled src/work_queue.erl
Compiled src/disco_main.erl
Compiled src/disco.erl
Compiled src/lock_server.erl
Compiled src/worker_inputs.erl
Compiled src/worker_throttle.erl
Compiled src/disco_server.erl
Compiled src/job_coordinator.erl
Compiled src/netstring.erl
Compiled src/disco_web.erl
Compiled src/disco_util.erl
Compiled src/disco_proxy.erl
Compiled src/ddfs/ddfs_web.erl
Compiled src/ddfs/http_queue.erl
Compiled src/discozip.erl
Compiled src/ddfs/ddfs_gc.erl
Compiled src/ddfs/ddfs_gc_node.erl
Compiled src/ddfs/ddfs_put.erl
Compiled src/ddfs/ddfs_node.erl
Compiled src/ddfs/ddfs_tag_util.erl
Compiled src/ddfs/ddfs_master.erl
Compiled src/ddfs/ddfs_get.erl
Compiled src/ddfs/ddfs_util.erl
Compiled src/ddfs/ddfs_http.erl
Compiled src/ddfs/ddfs.erl
Compiled src/json_validator.erl
Compiled src/temp_gc.erl
Compiled src/trunc_io.erl
Compiled src/fair_scheduler_fifo_policy.erl
Compiled src/disco_worker.erl
Compiled src/ddfs/ddfs_tag.erl
Compiled src/shuffle.erl
Compiled src/ddfs/ddfs_gc_main.erl
Compiled src/disco_config.erl
Compiled src/jobpack.erl
Compiled src/fair_scheduler.erl
ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ grep -r g4f2eeb2 .
./ebin/disco.app:              {vsn,"0.4.1-226-g4f2eeb2"},

Ryan Nowakowski

unread,
May 17, 2012, 12:33:24 PM5/17/12
to disc...@googlegroups.com
> > [snip]
> > ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$ grep -r g4f2eeb2 .
> > ./master/ebin/disco.app: {vsn,"0.4.1-226-g4f2eeb2"},
> > ry...@ec2-e-01.wopr:~/sandboxes/disco [master]$
> >
>
> It seems to be an issue with the way rebar handles {vsn, git} in app.src
> files. Even though "git describe" returns 0.4.2, rebar still uses 0.4.1 as
> it's git version.
>
> ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ git describe
> 0.4.2-4-gea5300d
> ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ grep -r g4f2eeb2 .
> ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ ./rebar compile
> [snip]
> ry...@ec2-e-01.wopr:~/sandboxes/disco/master [master]$ grep -r g4f2eeb2 .
> ./ebin/disco.app: {vsn,"0.4.1-226-g4f2eeb2"},

It looks like this is caused by a bug in rebar[1]

1. https://github.com/basho/rebar/issues/186

Bip Thelin

unread,
May 17, 2012, 12:52:29 PM5/17/12
to disc...@googlegroups.com
This is fixed in: https://github.com/basho/rebar/tree/ta-gitvsn

--
Bip Thelin
 
KIVRA | Lugnets Allé 1 | 120 33 Stockholm
Tel 08-533 335 37 | Mob 0735-18 18 90
www.kivra.com




--
You received this message because you are subscribed to the Google Groups "Disco-development" group.
To post to this group, send email to disc...@googlegroups.com.
To unsubscribe from this group, send email to disco-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/disco-dev?hl=en.


Reply all
Reply to author
Forward
0 new messages