Versioning for Dexterity content types

32 views
Skip to first unread message

Rafael Oliveira

unread,
Jul 13, 2011, 8:14:45 AM7/13/11
to dexterity-...@googlegroups.com
Hi,

I'm working on a project that needs versioning for Dexterity-based
content types. I then found plone.app.versioningbehavior but I saw
that there were some missing points in order to make versioning work
as well as it works for Archetypes-based content types:

- I had to specify the "diff type" for each field manualy on portal_diff.
- Diff for file fields was not working.
- Older versions were no being displayed on the versions_history_form template.

I've written two packages to fix these problems and a how-to [1] to
document the whole versioning story. I'm writing here to let you know
what I've done so far and ask for some help, since I'm not a Plone
core developer:

- Am I going in the right direction ?
- Review the code of the new packages and see if I'm doing something wrong.
- Review the how-to [1].
- Maybe the code on collective.cmfeditionsdexteritycompat could be
merged into CMFEditions.
- Perhaps add something in the Dexterity core documentation about versioning.
- Perhaps add the packages to the Dexterity KGS.

[1] http://plone.org/products/dexterity/documentation/how-to/adding-versioning-to-dexterity-content-types

Regards,

Rafael Bruno Cavalhero de Oliveira
Analista de Desenvolvimento de Sistemas - SERPRO
http://rafaelb.objectis.net

Martin Aspeli

unread,
Jul 21, 2011, 4:30:13 PM7/21/11
to dexterity-...@googlegroups.com
Hi,

I just wanted to say, I think this is awesome :-)

I don't have time to review this in the near term, but could you add a
ticket to the Dexterity issue tracker so we don't forget?

> - Am I going in the right direction ?

I think so, though some of this stuff may need merging later.

> - Review the code of the new packages and see if I'm doing something wrong.

This is the bit I need more time for than I have right now :(

> - Review the how-to [1].

It looks good!

> - Maybe the code on collective.cmfeditionsdexteritycompat could be
> merged into CMFEditions.

Perhaps, though CMFEditions can't have a Dexterity dependency. Maybe
put it in p.a.versioningbehavior?

> - Perhaps add something in the Dexterity core documentation about versioning.

I think that'd be a good, but maybe we should consider getting these
packages into p.a.versioningbehavior or similar first?

> - Perhaps add the packages to the Dexterity KGS.

+1 if we still need them

> [1] http://plone.org/products/dexterity/documentation/how-to/adding-versioning-to-dexterity-content-types

Martin

Rafael Oliveira

unread,
Jul 27, 2011, 7:40:49 AM7/27/11
to dexterity-...@googlegroups.com

I've added #221 to the tracker. I think the best thing to do is to
merge the two collective packages into p.a.versioningbehavior. I'm not
a Plone core developer though, so someone else will have to do this
work. One possible issue is that the two collective.* packages uses
p.a.testing, which p.a.versioningbehavior don't.

Rafael Oliveira

David Glick

unread,
Jul 27, 2011, 11:34:24 AM7/27/11
to dexterity-...@googlegroups.com, Rafael Oliveira
You should submit the contributor agreement and become a core developer!
http://plone.org/foundation/contributors-agreement

cheers,
David

Rafael Oliveira

unread,
Jul 27, 2011, 2:59:35 PM7/27/11
to David Glick, dexterity-...@googlegroups.com
I know, I know ... I'm trying to find some free time to work in the
Plone core :(

Rafael Bruno Cavalhero de Oliveira
Analista de Desenvolvimento de Sistemas - SERPRO
http://rafaelb.objectis.net

David Glick

unread,
Jul 27, 2011, 3:02:07 PM7/27/11
to Rafael Oliveira, dexterity-...@googlegroups.com
On 7/27/11 11:59 AM, Rafael Oliveira wrote:
> I know, I know ... I'm trying to find some free time to work in the
> Plone core :(
Yeah, I didn't mean to nag. It's just that the rest of us have limited
free time too, so the best way to make sure your versioning stuff gets
merged is to do it yourself. We'd be happy to have you contribute!
best,
David

cewing

unread,
Sep 17, 2012, 9:05:19 PM9/17/12
to dexterity-...@googlegroups.com
I'm facing a need for this work on a project right now.  I would like to step up and take care of moving the code into p.a.versioningbehavior, since this appears to be the consensus opinion so far.  In addition, I'd like to see if I can convert the handling of field-type to diff-type resolution to adaptation.  It seems more easily extensible in this case.

I'd also like to work on supplying diffs for content types that use tiles as well.  The current project has a number of types that use statically placed tiles in views, and I need to be able to calculate diffs between them.  That's probably a topic for a different thread, but I figure I'd mention it here.

First step to this will be moving the two packages from svn to github collective.  Look for that soon.

cewing

unread,
Sep 19, 2012, 11:51:37 PM9/19/12
to Dexterity development
On Sep 17, 6:05 pm, cewing <c...@crisewing.com> wrote:
>
> First step to this will be moving the two packages from svn to github
> collective.  Look for that soon.

Okay. All done:

http://github.com/collective/collective.dexteritydiff
http://github.com/collective/collective.cmfeditionsdexteritycompat

Reply all
Reply to author
Forward
0 new messages