Model.new(nil) blow up?

[trung]

is this intentional?

In rails and active record land. We can do this @model = Model.new
(params[:model]) and never have to worry checking for nil.

Now I have to do this @model = Model.new(params[:model] || {})

Thanks.

[Dan Kubb (dkubb)]

> is this intentional?

Not in this case. In other cases we've been somewhat strict,
especially in the DSL layer where it's important to specify behaviour
explicitly, but something like this we would generally want to handle
in DM.

> In rails and active record land. We can do this @model = Model.new
> (params[:model]) and never have to worry checking for nil.
>
> Now I have to do this @model = Model.new(params[:model] || {})

Submit a ticket and I'll fix that:

http://is.gd/aa86

--

Dan
(dkubb)

[Ashley Moran]

On Nov 25, 2009, at 3:18 am, Dan Kubb (dkubb) wrote:

>> is this intentional?
>
> Not in this case. In other cases we've been somewhat strict,
> especially in the DSL layer where it's important to specify behaviour
> explicitly, but something like this we would generally want to handle
> in DM.

I'm not sure. Devil's advocate: The case when no parameters are supplied feels to me like something that should be handled at the boundary of the application ... otherwise, isn't there a risk of user interface logic filtering down through the app?

I'd be interested to hear opinions.

Ashley

--
http://www.patchspace.co.uk/
http://www.linkedin.com/in/ashleymoran