[Refacoring] Factoring out cucumber-core?
Matt Wynne
refactoring, as well as pulling out gems for specific things like
formatters, might be to to try to separate the core domain of Cucumber
(parsing and executing features) from the CLI user-interface. We could
pull out the core stuff into another gem and leave only the user-
interface stuff behind in the actual cucumber gem.
There are a few advantages to this separation:
* it would force us to clean up the interface between the user-
interface (Cucumber::Cli::*) and the core feature parsing / running
stuff, which right now is quite messy.
* it would give us a clear place to start writing rdoc: for the core.
* it would allow tools like testjour to depend on just the cucumber-
core gem, rather than having the UI stuff as well.
* it might help people / us to think about building other UIs for
Cucumber than the CLI.
WDYT?
cheers,
Matt Wynne
aslak hellesoy
Gherkin. That will require quite a bit of internal refactoring and
things can get messy if we have two parallel refactoring efforts.
Let's call it 0.5 when we have Gherkin. Then we can do what you suggest for 0.6.
WDYT?
Aslak
Stephen Eley
>
> * it might help people / us to think about building other UIs for
> Cucumber than the CLI.
+1. Maybe +2, if I get enough points for that.
--
Have Fun,
Steve Eley (sfe...@gmail.com)
ESCAPE POD - The Science Fiction Podcast Magazine
http://www.escapepod.org
Paul Campbell
mixed marketing message.
eg. Rails (ActiveRecord, ActionPack etc.)
merb-more, merb-core
I prefer the monolithic thing, where it would be
Cucumber (cucumber-cli, gherkin, cucumber-core)
rather than being generally "available" separately.
It makes no difference to the organisation of the code at the end of
the day, but I think it's important to the marketing message that it's
a coherent whole, albeit one that's very well organised into distinct
interoperating parts!
Paul
Paul Campbell
pa...@rushedsunlight.com
- - - - - - - - - - - - - - - - - - -
blog http://www.pabcas.com
twitter http://www.twitter.com/paulca
github http://www.github.com/paulca
phone +353 87 914 8162
- - - - - - - - - - - - - - - - - - -
Jim Meyer
> On Wed, Oct 14, 2009 at 4:40 AM, Matt Wynne <ma...@songkick.com> wrote:
>>
>> * it might help people / us to think about building other UIs for
>> Cucumber than the CLI.
>
> +1. Maybe +2, if I get enough points for that.
I'll loan you mine just in case.
+1
--j
Jim Meyer
> Definitely a good plan, although sometimes stuff like this sends a
> mixed marketing message.
>
> eg. Rails (ActiveRecord, ActionPack etc.)
> merb-more, merb-core
>
> I prefer the monolithic thing, where it would be
>
> Cucumber (cucumber-cli, gherkin, cucumber-core)
>
> rather than being generally "available" separately.
If I follow you, you're saying that 'gem install cucumber' should
install all the basics required to write and execute a feature from
the command line as we do now; under the hood it's really a thin
dependancy wrapper to install cucumber-{core,cli} and gherkin, which
makes it easy for other gems to just pull in cucumber-core.
+1 for that, and apologies if I've got your intent wrong.
--j
Mike Sassak
opinion is on the matter: big +1. Especially for alternate UIs.
Greg and I are planning on bringing the pain, err... pair-programming
to Gherkin in the next few days, so hopefully 0.5 won't be (too) far
off.
Mike
Paul Campbell
> install all the basics required to write and execute a feature from
> the command line as we do now; under the hood it's really a thin
> dependancy wrapper to install cucumber-{core,cli} and gherkin, which
> makes it easy for other gems to just pull in cucumber-core.
should stay that way.
>
> +1 for that, and apologies if I've got your intent wrong.
>
> --j
>
> >
>
Matt Wynne
On 14 Oct 2009, at 17:23, Paul Campbell wrote:
>
>> If I follow you, you're saying that 'gem install cucumber' should
>> install all the basics required to write and execute a feature from
>> the command line as we do now; under the hood it's really a thin
>> dependancy wrapper to install cucumber-{core,cli} and gherkin, which
>> makes it easy for other gems to just pull in cucumber-core.
>
> Exactly! Things "just work" great right now, and I think that it
> should stay that way.
Yes, that's exactly what I'm suggesting. I'd just like the layers
underneath, should you care to look down there, to have clearer
separation which will make Cucumber more extensible in the long game.
cheers,
Matt