Hi,
On Thursday, 9 August 2012, flipm0de wrote:
> In Community.CsharpSqlite.SQLiteClient.SqliteParameterCollection.cs
> ...
> Should be:
> private bool isPrefixed (string parameterName)
> {
> return parameterName.Length > 1 && (parameterName [0] == ':'
> || parameterName [0] == '$' || parameterName [0] == '@');
> }
> I agree.
On Thursday, 9 August 2012, flipm0de also wrote:
> And in Community.CsharpSqlite.SQLiteClient.SqliteConnection.cs
> line 177:
> string[] conn_pieces = connstring.Split (',');
> should be:
> string [] conn_pieces = connstring.Split (';');
Or, string[] conn_pieces = connstring.Split (new char[]{';',','},
StringSplitOptions.RemoveEmptyEntries);
This alternative maintains the current working behaviour, and still meets
expectations of developers coming from the C++ implementation. It also
eliminates worries caused by connection strings with ",," or ";;".
Regards,
Stewart.