CrystalHD - hardware deinterlacing [PATCH]

[R.M.]

Hello,
I wrote some code to support hw deinterlacing ... function always
return BC_STS_SUCCESS, but hw deinterlacing dosn't work

please help or if You can send docs for firmware

thanks,
R.M.

DRVIFLIB_INT_API BC_STATUS
DtsFWSetHardwareDeinterlacing(
HANDLE hDevice
)
{
BC_STATUS sts = BC_STS_SUCCESS;
DTS_LIB_CONTEXT *Ctx = NULL;
BC_IOCTL_DATA *pIocData = NULL;
DTS_GET_CTX(hDevice,Ctx);

if((Ctx->State == BC_DEC_STATE_CLOSE)){
DebugLog_Trace(LDIL_DBG,"DtsFWSetHardwareDeinterlacing:
Channel not opened\n");
return BC_STS_DEC_NOT_OPEN;
}

if(!(pIocData = DtsAllocIoctlData(Ctx)))
return BC_STS_INSUFF_RES;

if (Ctx->DevId == BC_PCI_DEVID_FLEA)
{
DecCmdChannelSetOutputFormatting *outputFormatting;
DecRspChannelSetOutputFormatting *pRsp;

outputFormatting =
(DecCmdChannelSetOutputFormatting*)&pIocData->u.fwCmd.cmd;
outputFormatting->command =
eCMD_C011_DEC_CHAN_OUTPUT_FORMAT;
outputFormatting->sequence = ++Ctx->fwcmdseq;
outputFormatting->deinterlacing = eC011_DEINTERLACING_ON;

DebugLog_Trace(LDIL_DBG,"Enabling hardware deinterlacing...
\n");

if( (sts=DtsDrvCmd(Ctx,BCM_IOC_FW_CMD,1,pIocData,FALSE)) !=
BC_STS_SUCCESS){
DtsRelIoctlData(Ctx,pIocData);
DebugLog_Trace(LDIL_DBG,"DtsFWSetHardwareDeinterlacing:
Ioctl failed: %d\n",sts);
return sts;
}

pRsp = (DecRspChannelSetOutputFormatting*) &pIocData-
>u.fwCmd.rsp;

if(pRsp->status){
DebugLog_Trace(LDIL_DBG,"DtsFWSetHardwareDeinterlacing:
Failed %d\n",pRsp->status);
DtsRelIoctlData(Ctx,pIocData);
return BC_STS_FW_CMD_ERR;
}

}
else
{
return BC_STS_FW_CMD_ERR;
}

DtsRelIoctlData(Ctx,pIocData);

return BC_STS_SUCCESS;
}

[Philip Langdale]

I haven't seen any indication that HW deinterlacing actually works. There
may be some firmware flags but it's not exposed in the library API and I've
never seen any product documentation that indicates its a supported
feature.

Naren is really the only person who can say if it works or not, but I seriously
doubt it does; otherwise I'd hope he'd have pointed it out to me while I was
banging my head against all the different variations of interlaced content...

--phil