Account Options

  1. Sign in
The old Google Groups will be going away soon.
Switch to the new Google Groups.
Google Groups Home
« Groups Home
patch: trivial compile fix for Visual Studio 2010 / VC10
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Patrick Dawson  
View profile  
 More options Dec 17 2009, 6:12 pm
From: Patrick Dawson <pkdaw...@gmail.com>
Date: Thu, 17 Dec 2009 15:12:18 -0800 (PST)
Local: Thurs, Dec 17 2009 6:12 pm
Subject: patch: trivial compile fix for Visual Studio 2010 / VC10
VC10 apparently wants an explicit cast of NULL to the appropriate type
in a std::pair. This was the only change necessary to get Crypto++ to
compile without errors on Visual Studio 2010 Beta 2.

--- pubkey.h.orig       2009-12-17 18:03:49.000000000 -0500
+++ pubkey.h    2009-12-17 18:04:21.000000000 -0500
@@ -240,7 +240,7 @@
                {
                        static HashIdentifier CRYPTOPP_API Lookup()
                        {
-                               return HashIdentifier(NULL, 0);
+                               return HashIdentifier(static_cast<const byte*>(NULL), 0);
                        }
                };
        };


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Patrick Dawson  
View profile  
 More options Dec 18 2009, 10:02 am
From: Patrick Dawson <pkdaw...@gmail.com>
Date: Fri, 18 Dec 2009 07:02:10 -0800 (PST)
Local: Fri, Dec 18 2009 10:02 am
Subject: Re: patch: trivial compile fix for Visual Studio 2010 / VC10
Oops, I missed something in zdeflate.cpp. Wei Dai is obviously already
aware of this issue, but in case anyone else needs to compile Crypto++
in VC10 right now, here's the full patch.

I believe this is the appropriate fix, based on the response from
Microsoft here:
http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?...

This was written against the SVN trunk, but it also applies to an
unmodified Crypto++ 5.6.0. Building everything in cryptest.sln works,
and all the cryptest validation tests pass (Win32/x64 Debug/Release).

Index: zdeflate.cpp
===================================================================
--- zdeflate.cpp        (revision 479)
+++ zdeflate.cpp        (working copy)
@@ -386,7 +386,7 @@
                {
                        assert(scan[2] == match[2]);
                        unsigned int len = (unsigned int)(
-#if defined(_STDEXT_BEGIN) && !(defined(_MSC_VER) && _MSC_VER < 1400)
&& !defined(_STLPORT_VERSION)
+#if defined(_STDEXT_BEGIN) && !(defined(_MSC_VER) && (_MSC_VER < 1400
|| _MSC_VER >= 1600)) && !defined(_STLPORT_VERSION)
                                stdext::unchecked_mismatch
 #else
                                std::mismatch
Index: pubkey.h
===================================================================
--- pubkey.h    (revision 479)
+++ pubkey.h    (working copy)
@@ -240,7 +240,7 @@
                {
                        static HashIdentifier CRYPTOPP_API Lookup()
                        {
-                               return HashIdentifier(NULL, 0);
+                               return HashIdentifier(static_cast<const byte*>(NULL), 0);
                        }
                };
        };


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »