Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Next steps
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Dirkjan Ochtman  
View profile  
 More options Feb 9 2010, 11:39 am
From: Dirkjan Ochtman <dirk...@ochtman.nl>
Date: Tue, 9 Feb 2010 17:39:41 +0100
Local: Tues, Feb 9 2010 11:39 am
Subject: Re: Next steps

On Tue, Feb 9, 2010 at 17:34, Matt Goodall <matt.good...@gmail.com> wrote:
> * ResponseBody.__iter__ only works for chunked responses. If someone tries
> to iterate a non-chunked response then it will end up eating real data as
> chunk headers. Need to check for a "Transfer-Encoding: chunked" header
> first, but see below.

Yes, this is by design. I think it should be an iterator over chunks.

> * There's a CRLF, i.e. an empty chunk, after the final 0 chunk header but
> it's not being read at the moment. That's possibly leaving the connection in
> an invalid state for the next request on the socket.

Okay, we should fix that.

> * ResponseBody.__iter__ still isn't yielding lines. It now yields chunks. A
> chunk happens to be a line for a changes feed but that's not going to be
> true for other requests and CouchDB could start sending multiple lines in a
> chunk in the future.

Right.

> * There's nothing in Database._changes that reads the remainder of the
> response so it's not returning the connection to the pool any more.

I think it should be right now, though this maybe requires more testing.

Cheers,

Dirkjan


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.