compojure.http.multipart -> ServletFileUpload?
12 views
Skip to first unread message
Adam Blinkinsop
Aug 17, 2009, 5:55:31 PM8/17/09
to Compojure
Has anyone thought about patching multipart to work with
ServletFileUpload (http://commons.apache.org/fileupload/apidocs/org/
apache/commons/fileupload/servlet/ServletFileUpload.html) instead of
just FileUpload? Are there problems with dependencies there?
Google App Engine has documentation on how to do this, it seems like a
pretty straightforward change: http://code.google.com/appengine/kb/java.html#fileforms
(Note that this would also make it work on App Engine with no further
changes. I was thinking about making the change myself, but I'm not
sure about how to keep the API stable.)
ServletFileUpload (http://commons.apache.org/fileupload/apidocs/org/
apache/commons/fileupload/servlet/ServletFileUpload.html) instead of
just FileUpload? Are there problems with dependencies there?
Google App Engine has documentation on how to do this, it seems like a
pretty straightforward change: http://code.google.com/appengine/kb/java.html#fileforms
(Note that this would also make it work on App Engine with no further
changes. I was thinking about making the change myself, but I'm not
sure about how to keep the API stable.)
Adam Blinkinsop
Aug 18, 2009, 1:39:30 PM8/18/09
to Compojure
I did this in my fork: http://github.com/blinks/compojure/commit/1e5ab06c5d9a6cc4c94fdd76b0991f3d80bd61fa
Currently running on App Engine, if anyone wants to pull it apart.
James Reeves
Aug 20, 2009, 8:14:22 PM8/20/09
to Compojure
On Aug 18, 1:39 pm, Adam Blinkinsop <hackerbli...@gmail.com> wrote:
> I did this in my fork:http://github.com/blinks/compojure/commit/1e5ab06c5d9a6cc4c94fdd76b09...
look at this, but I'll do so the day I get back (or at least once I've
recovered from jetlag). Potentially this might be useful for Ring as
well.
The only thing I'd suggest is to split out the .gitignore addition
into a separate commit.
- James
> I did this in my fork:http://github.com/blinks/compojure/commit/1e5ab06c5d9a6cc4c94fdd76b09...
> Currently running on App Engine, if anyone wants to pull it apart.
I'm currently on business in New York, so I haven't had much chance to
look at this, but I'll do so the day I get back (or at least once I've
recovered from jetlag). Potentially this might be useful for Ring as
well.
The only thing I'd suggest is to split out the .gitignore addition
into a separate commit.
- James
Adam Blinkinsop
Aug 20, 2009, 11:32:57 PM8/20/09
to comp...@googlegroups.com
Koichiro Ohba
Oct 14, 2009, 11:57:13 AM10/14/09
to Compojure
Hi,
I used Adam's fork of Compojure and it worked fine on GAE/J.
Thank you !
On 8月21日, 午後12:32, Adam Blinkinsop <hackerbli...@gmail.com> wrote:
I used Adam's fork of Compojure and it worked fine on GAE/J.
Thank you !
On 8月21日, 午後12:32, Adam Blinkinsop <hackerbli...@gmail.com> wrote:
James Reeves
Oct 14, 2009, 2:13:51 PM10/14/09
to Compojure
Oops, I'd forgotten about this. I'll merge it into my branch, as soon
as Github lets me pull blink's branch.
- James
as Github lets me pull blink's branch.
- James
Andrew
Dec 7, 2009, 6:33:09 AM12/7/09
to Compojure
Hi,
I was having a bit of a fiddle with compojure and GAE tonight and ran
into the issue described here. The link to Adam's fork didn't work.
Is this available anywhere else?
Andrew.
I was having a bit of a fiddle with compojure and GAE tonight and ran
into the issue described here. The link to Adam's fork didn't work.
Is this available anywhere else?
Andrew.
James Reeves
Dec 7, 2009, 4:06:36 PM12/7/09
to Compojure
I was never able to get the fork to work, I'm afraid. The re-written
with-multipart middleware seemed to expect a HttpServletRequest,
rather than a request map.
- James
with-multipart middleware seemed to expect a HttpServletRequest,
rather than a request map.
- James
Andrew
Dec 7, 2009, 7:27:12 PM12/7/09
to Compojure
Thanks James.
So does anyone have compojure working against a recent GAE SDK? This
is more just for my own curiosity than any pressing need I have for it
though.
So does anyone have compojure working against a recent GAE SDK? This
is more just for my own curiosity than any pressing need I have for it
though.
chylli
Dec 28, 2009, 10:28:11 PM12/28/09
to Compojure
I want to know that too.
Reply all
Reply to author
Forward
0 new messages