Logging, awesome?

[LauJensen]

Hi group,

I decided that my new website, which is driven only by compojure,
needed a webcounter for statistics. From the top of my head I just
added this bit of code and I'd like some feedback. Is this awesome?

(defn log
[request]
(let [header (apply merge
(for [[k v] (:headers request)]
{(keyword k) v}))]
(run *mysql-connection*
(insert-into traffic [logged ~(java.util.Date.)
remote ~(:remote-addr request)
method ~(.toUpperCase (name
(:request-method request)))
query ~(:query-string request)
params ~(apply str (:route-params
request))
uri ~(:uri request)
referer ~(:referer header)
agent ~(:user-agent header)]))))

(defn with-logging
[handler]
(fn [request]
(log request)
(handler request)))

(run-server {:port 8888}
"/*"
(servlet
(with-logging
main-servlet)))

[Lau]

By the by. If anyones interested, the site is up at

http://www.bestinclass.dk

/Lau