Message from discussion
Patch: Elm ME+ 2.5 PLalpha29 -> Elm ME+ 2.5 PLalpha30 [0/2]
Received: by 10.224.39.72 with SMTP id f8mr8007852qae.7.1342999949445;
Sun, 22 Jul 2012 16:32:29 -0700 (PDT)
Received: by 10.66.89.225 with SMTP id br1mr1388106pab.3.1342999871301;
Sun, 22 Jul 2012 16:31:11 -0700 (PDT)
Path: a15ni59622917qag.0!nntp.google.com!x2no5801137qaj.0!news-out.google.com!p10ni26438773pbh.1!nntp.google.com!npeer02.iad.highwinds-media.com!news.highwinds-media.com!feed-me.highwinds-media.com!border3.nntp.dca.giganews.com!border1.nntp.dca.giganews.com!nntp.giganews.com!ctu-peer!news.nctu.edu.tw!goblin2!goblin.stu.neva.ru!newsfeed1.swip.net!newsfeed3.funet.fi!newsfeeds.funet.fi!feeder2.news.elisa.fi!uutiset.elisa.fi!7564ea0f!not-for-mail
From: Kari Hurtta <hur...@klovni.keh.iki.fi>
Newsgroups: alt.sources,comp.mail.elm
Subject: Patch: Elm ME+ 2.5 PLalpha29 -> Elm ME+ 2.5 PLalpha30 [0/2]
Followup-To: comp.mail.elm,alt.sources.d
Message-ID: <elmME+2.5/PLalpha30/1-0@klovni.keh.iki.fi>
References: <HURTTA.96Jan14171148@dionysos.FMI.FI>
<elmME+2.5/PLalpha7/1@attruh.keh.iki.fi>
<elmME+2.5/PLalpha8/1@attruh.keh.iki.fi>
<elmME+2.5/PLalpha9/1@attruh.keh.iki.fi>
<elmME+2.5/PLalpha10/1@attruh.keh.iki.fi>
<elmME+2.5/PLalpha11/0@attruh.keh.iki.fi>
<elmME+2.5/PLalpha12/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha13/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha14/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha15/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha16/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha17/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha18/1-0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha19/0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha20/1@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha21/2@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha22/1-0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha23/1-0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha24/1-0@Hurtta06k.keh.iki.fi>
<elmME+2.5/PLalpha25/1-0@klovni.keh.iki.fi>
<elmME+2.5/PLalpha26/1-0@klovni.keh.iki.fi>
<elmME+2.5/PLalpha27/1-0@klovni.keh.iki.fi>
<elmME+2.5/PLalpha28/1@klovni.keh.iki.fi>
<elmME+2.5/PLalpha29/...@klovni.keh.iki.fi>
Reply-To: "Kari E. Hurtta" <elm @elmme-mailer.org>
In-Reply-To: <elmME+2.5/PLalpha29/...@klovni.keh.iki.fi>
<elmME+2.5/PLalpha29/...@klovni.keh.iki.fi>
<elmME+2.5/PLalpha29/...@klovni.keh.iki.fi>
<elmME+2.5/PLalpha29/...@klovni.keh.iki.fi>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
Cancel-Lock: sha1:Yh+FSMvUMH2P8JDlScQTcYEY4ME=
MIME-Version: 1.0
Lines: 528
Date: Mon, 16 Jul 2012 10:31:45 +0300
NNTP-Posting-Host: 62.78.144.32
X-Complaints-To: newsmas...@saunalahti.com
X-Trace: uutiset.elisa.fi 1342423915 62.78.144.32 (Mon, 16 Jul 2012 10:31:55 EEST)
NNTP-Posting-Date: Mon, 16 Jul 2012 10:31:55 EEST
Organization: Elisa Customer
Bytes: 25445
X-Received-Bytes: 25494
Content-Type: text/plain; charset=us-ascii
Archive-name: elmME+2.5/PLalpha30.0
Elm ME+ 2.5 PLalpha30
Before applying patch catenate parts 1 - 2 first.
Also it should be possible to apply parts 1 - 2
individually.
Part 0 do not include patch.
This patch is agaist Elm ME+ 2.5 PLalpha29
====================================== ( part 0/2 ) =========
Elm ME+ 2.5 PLalpha30
- Is available with
<URL: http://www.elmme-mailer.org/elm-ME+2.5/src/elm-ME+2.5.PLalpha30.patch.gz >
and <URL: http://www.elmme-mailer.org/elm-ME+2.5/src/elm-ME+2.5.alpha30.tar.gz >
via WWW.
- Is available on ftp.funet.fi
via anonymous ftp
directory pub/mirrors/elmme-mailer.org/mirror/src/elm-ME+2.5/
or pub/unix/mail/elm/elm-ME+2.5/
files elm-ME+2.5.PLalpha30.patch.gz
and elm-ME+2.5.alpha30.tar.gz
or is available with
<URL: http://www.nic.funet.fi/pub/unix/mail/elm/elm-ME+2.5/elm-ME+2.5.PLalpha30.patch.gz >
and <URL: http://www.nic.funet.fi/pub/unix/mail/elm/elm-ME+2.5/elm-ME+2.5.alpha30.tar.gz >
via WWW.
SUMMARY: This release changes implementation of
"pager", "editor" and "alteditor" elmrc
variables, fixes some bugs (including
crash when file with too long file name is
attached) and changes elm.rc help texts.
Before applying patch catenate parts 1 - 2 first.
Also it should be possible to apply parts 1 - 2
individually.
Part 0 do not include patch.
For applying thich patch use (on directory where Configure is)
patch -p1 < {catenated-file}
Changes on Elm ME+ 2.5 PLalpha30 compared with Elm ME+ 2.5 PLalpha29
--------------------------------------------------------------------
SUMMARY: This release changes implementation of
"pager", "editor" and "alteditor" elmrc
variables, fixes some bugs (including
crash when file with too long file name is
attached) and changes elm.rc help texts.
- Changed that give_dt_estr_as_str() returns const char *
instead of char *. Changed many function that they
take const char * instead of char * as argument.
- Added join_argvc1() to lib/syscall.c
- Changed that have_printout() returns const char *
instead of char *.
- Changed that have_metamail() returns const char *
instead of char *.
- Added error message "Mailer (type %s) assumed"
- Changed configure search first /var/mail
instead of /usr/spool/mail for incoming mail
spool directory.
- Changed comments referring bzero on hdrs/defs.h
to refer bzero on hdrs/elm_defs.h
- Used have_metamail() on show_msg()
- Fixed some misspellings.
Patch from: Vandeir Silva <vand...@silva.info>
- Added a missing function in the "write_rc.c" to print
the ".elm/elmrc - options file for the ELM mail system"
line.
Patch from: Vandeir Silva <vand...@silva.info>
> That text was on src/save_opts.c and
probably lost on Elm ME+ 2.5 PLalpha5
and Elm 2.4ME+ PL122 (25). Added also condition
that this text is not written when writing global
elm.rc.
- Changed help text of "pagealternative" elmrc
option on doc/elmrc-info.
Patch from: Vandeir Silva <vand...@silva.info>
- Fixed some texts on doc/elmrc-info.
From: Vandeir Silva <vand...@silva.info>
- Changed elmrc rc_DT_ESTR variables implementation
so that they can take keywords (on first line)
and list of flags on continuation line. Possible
flags are reset when elmrc rc_DT_ESTR variable is set.
- Changed that give_dt_estr_as_str() so that it
takes parameters (pointers) for reading possible keyword
and these flags of elmrc rc_DT_ESTR variable.
- Added ESTR_print_expanded flag to elmrc rc_DT_ESTR variables.
If that flag is set, text after # character is ignored
for variable value and expanded value is written after
# character when variable is saved to elmrc or
global elm.rc
- Changed "pager" elmrc variable so that values
"builtin", "builtin+", "builtin++", "internal" are
implemented as rc_DT_ESTR variable keywords.
- Added value "use-$PAGER" for use as continuation line
flag on "pager" elmrc variable. That flag is set by
default (if compilation time definition USE_BUILTIN_PAGER is
not used), but it is reset when "pager" elmrc variable
is set.
- After # character there is written expanded value
of "pager" variable on elmrc file when it is saved.
- Changed "editor" elmrc variable so that values
"builtin", "internal" are implemented as rc_DT_ESTR
variable keyword.
- Added value "use-$EDITOR" for use as continuation line
flag on "editor" elmrc variable. That flag is set by
default , but it is reset when "editor" elmrc variable
is set.
- After # character there is written expanded value
of "editor" variable on elmrc file when it is saved.
- Value "none" on "editor" and "pager" elmrc variables
is handled also specially.
- Some compilation fixes for genlib.c on
Ubuntu 10.04.4 LTS
- Fixed crash on gen_splitted_ascii_param()
when file with too long filename was attached:
Couldn't malloc -79 bytes!!
PANIC in utils.c:92:malloc_failed_exit
>>>Out of memory
Call stack: 6405A6 80DFFDA 6514C8 C3ED27 C3F6AC
continues: 80733B5 80772F4 80A2E96 80887B5 9A0BD6
continues: 805F891
backtrace:
/usr/local/lib/libelmme-base.so.1.1.29+(panic+0x1e8)[0x6405a6]
bin/elm-shared(malloc_failed_exit+0xe2)[0x80dffda]
/usr/local/lib/libelmme-base.so.1.1.29+(safe_malloc+0x7c)[0x6514c8]
/usr/local/lib/libelmme-mime.so.1.1.29+(+0x16d27)[0xc3ed27]
/usr/local/lib/libelmme-mime.so.1.1.29+(mime_params_add+0x1f1)[0xc3f6ac]
bin/elm-shared[0x80733b5]
bin/elm-shared(Check_attachments+0xa8)[0x80772f4]
bin/elm-shared(initialize+0xaab)[0x80a2e96]
bin/elm-shared(main+0xe7)[0x80887b5]
- Changed that malloc_failed_exit() used %u on instead
of %d in error message because argument is
'unsigned len'
> That changes crash message to
Couldn't malloc 4294967217 bytes!!
- Reimplemented elmrc variable "alteditor" as rc_DT_ESTR
- Changed "alteditor" elmrc variable so that value "EDITOR"
is implemented as rc_DT_ESTR variable keyword.
WARNING: On some situations "alteditor = EDITOR" may
use old value of "editor" when value of "editor"
is changed after value of "alteditor" elmrc
variable is set.
- Added value "use-$EDITOR" for use as continuation line
flag on "alteditor" elmrc variable. That flag is set by
default , but it is reset when "alteditor" elmrc variable
is set.
- After # character there is written expanded value
of "alteditor" variable on elmrc file when it is saved.
- Value "none" on "alteditor" elmrc variables
is handled also specially.
- Added value "use-$VISUAL" for use as continuation line
flag on "editor" and "alteditor" elmrc variables. That
flag is set by default , but it is reset when "alteditor"
elmrc variable is set. If both environment variables
$VISUAL and $EDITOR are set and both continuation line
flags "use-$EDITOR" and "use-$VISUAL" are set, then
$EDITOR environment variable is used.
- Used have_editor() on edit_a_file() on src/edit.c
- Used have_editor() on attach_edit () on src/attach_menu.c
- Changed edit_the_message() so that NULL is passed
as editor if "editor" or "alteditor" elmrc
variable is used.
- Fixed e)dit -command menu text on aliases.
- Added menu_trigger_redraw(page) to edit_a_file()
Warnings
--------
- Not compiled with MMDF support defined, so probably it doesn't
work (or even compile).
- This has not been tested much so there can be bad bugs.
Bug reports to: Kari E. Hurtta <e...@elmme-mailer.org>
(was hurtta+...@posti.FMI.FI)
- Internationalized (ie. non-ASCII) domain names are not supported.
- Support for multipart/signed and multipart/encrypted (specially:
support for PGP/MIME) only in reading side. There is no support
for attachments with multipart/encrypted.
- HP's shoftkeys are no longer supported
- DECNET addresses like host::user may be interpreted as phrase
of group syntax or as route of source routed address.
- Header editing screen now uses addresses in form phrase <address>,
but because it does not require using of comma (,), multiword
phrases must be entered in quotes.
For example: "Kari Hurtta" <hurtta>
- If address includes <> or comments (), they are not aliased
expanded. So aliases must be entered as bare words.
- Addresses given as arguments to elm command should be given
as one address per argument. Giving of sevaral addresses per
one argument causes that address is misparsed if header is
edited on header editing screen.
That is:
Use: elm '"Kari Hurtta" <hurtta>' 'Admin <root>'
Don't use: elm 'Kari Hurtta <hurtta>, Admin <root>'
- p)rint command acts as P)rint text -command. So it
is currently quite useless.
p)rint command does that via readmsg -command. However
P)rint text does actually same (without readmsg).
- Some Linux libraries does not follow $LC_CTYPE when program is
setgid. Net result is that your locale is always C. That is
visible that $LC_CTYPE does not effect to locale printed by
'elm -vvvvv':
Locale (LC_CTYPE): C
Display character-set: US-ASCII
Sending character-set: US-ASCII
- Some linux libraries does not allow resetting scanning
of argument vector with getopt() be setting optind = 1.
On that case installation fails.
- All refrences iso2022 maps are parsed and read to memory.
This may cause quite big memory consumption specially because
eastern (multibyte) sets tend to be lot of characters. That
mapping information should be shared between processes to
reduce memory consuption.
- If display charset is produced by using mapping from locale
to charset where charset definition is later invalidated
("removed") by setting explicit compatcharsets on user's
.elm/elmrc, that may cause PANIC on elm's internal pager
or other problems. Invalidation happens if display charset
is on implicit compatcharsets list (because of charset
definition), but does not have explicit compatcharsets list
given by user.
- Neither Unicode didirectional algorithm nor Right-Left scripts
are supported.
- In some situations two Status headers may be generated two
Status headers -- one by IMAP deamon and one from APPENDed
message.
- When APPENDing message to IMAP folder (which is normal UNIX
mailbox format) original "From " separator line can not be
preserved -- specially it is not possible to pass envelope
sender address.
- For UTF-8 charset Elm only knows printable characters from
Latin/1 range, if unicode database (see elmrc option "unidata")
is not loaded.
- For using of ISO2022 character sets it is required that mapping
them to unicode is know -- otherwise Elm ME+ does not know which
characters are printable.
- UTF-16 surrogate pairs (D800-DFFF) are not supported on UTF-7
charset.
- Mixing of names using IMAP naming convention
(imap-naming-convention = yes)
and names using imap-charset does not work very well...
- Some Linux gethostbyname implementations accept ip-address as
name, but return garbage on h_name -field of struct hostent.
- " Regarding my message (8 Aug 2000) regarding 'newmail' on
AIX 4.3.3 in an 'aixterm' window and the 'aixterm' did not
close, indeed the problem was NOT related to 'newmail' but an
AIX bug.
IBM has release a patch, and the 'aixterm' in AIX 4.3.3 must
be update with fileset X11.apps.aixterm.4.3.3.26 (PTF
U473920) is solved to problem."
From: Noam G. Nudelman <n...@mail.biu.ac.il>
- File /usr/share/locale/fi/charset gives charset name utf-8 on
Linux Mandrake 7.2. This causes that Configure generates
mapping
fi utf-8
to elm.mimecharsets. However that seems to have
incorrect mapping. You may want change this to
fi ISO-8859-1
( however nl_langinfo(CODESET) gives charset ISO-8859-15
but look following entry. )
- Locale 'fi' seems to have charset ISO-8859-15 according
of nl_langinfo(CODESET) on Mandrake Linux 7.2 (and probaly
others with same glibc version). However for example gnome
terminal uses font
-misc-fixed-medium-r-normal--12-200-75-75-c-100-iso8859-1
and not
-misc-fixed-medium-r-normal--12-200-75-75-c-100-iso8859-15
Also KDE's konsole program seems use iso8859-1 character set
although locale is 'fi' which should have ISO-8859-15 according
of nl_langinfo (selecting "unicode" from menu seems fix that.)
Because of mismatch more correct locale is fi_FI.88591, which gives
ISO-8859-1 character set according of nl_langinfo(CODESET).
( Locale seems come from /etc/sysconfig/i18n or $HOME/.i18n )
> To enable handling of ISO-8859-1 and ISO-8859-15 character sets
on linux console, read comments from doc/terminal.info file.
- Mandrake Linux 7.2 seems set LD_PRELOAD to load
/usr/lib/libxalflaunch.so.0. That (xalf-0.4-2mdk) causes that
elm to crash on startup (actually before main() is reached.)
- kterm on Mandrake Linux 7.2 seems have (at least on my test
environment) seems get bad fontlist (*VT100*fontList) which
gives bad font for iso8859-1 -- therefore ISO-8859-1 characters
do not work.
("xrdb -query" seems report resource with name "*fontList"
-- that probably overrides "*VT100*fontList" which comes
from /usr/lib/X11/app-defaults/KTerm )
- Also note that initially kterm does NOT default to
ISO-8859-1 -- therefore ISO-8859-1 works only when
elm explicity switch to ISO-8859-1 (for example
with 'elm -D ISO-8859-1')
- When assembling message/partial MIME (RFC 2046)
requires that all headers except Content-*, Subject,
MIME-Version, Message-ID and Encrypted are copied from
initial enclosing message to assembled message. It also
requires that headers except Content-*, Subject,
MIME-Version, Message-ID and Encrypted are ignored and
dropped from enclosed message.
For now we copy only Received: -headers. Dropping extra
headers from enclosed message makes assembly more
complicated (and dropping of Received: -headers
from enclosed message do not make sense.)
- EXIF files are sometimes labeled with content-type
image/jpeg. They also use .jpg filename extension. They are
not accepted by Elm ME+ as image/jpeg because magic number
(and format) is different. It is unclear what is correct
treatment. According of specification EXIF files may
wrap also other file types than jpeg (JFIF).
- mailer=sendmail; verify=yes works only when sendmail
is installed as setuid root. Use mailer=submission instead.
* Starting from sendmail 8.12 sendmail is normally
installed as setgid smmsp and not as setuid root.
- However error message is printed only if
verify-local-address=yes is also set
- IMAP connection is stalled some times. Reason is unknown.
- From name option (-f) on fastmail is currently broken.
Collector of these patches
--------------------------
Kari Hurtta <e...@elmme-mailer.org>
Kari Hurtta <hurtta+...@siilo.FMI.FI>
diffstat:
Configure | 14 !
README.ME+ | 184 +++++++++++++!!!
doc/elm.1 | 14 !
doc/elmrc-info | 57 ++!!!
hdrs/connection_imp.h | 6
hdrs/elmlib.h | 53 !!!!
hdrs/mboxlib.h | 6
hdrs/mbxlocal_imp.h | 8
hdrs/me.h | 15 !
hdrs/patchlevel.h | 10
hdrs/rc_imp.h | 15 !
hdrs/s_aliases.h | 2
hdrs/s_elm.h | 5
hdrs/save_opts.h | 50 +++
lib/addr/addr_list.c | 6
lib/addr/address.c | 6
lib/addr/error.c | 6
lib/addr/getaddr.c | 6
lib/addr/message-id.c | 6
lib/addr/mlist.c | 6
lib/addr/outheaders.c | 9
lib/addr/references.c | 12 !
lib/alias/aliases.c | 6
lib/expand.c | 14 !
lib/in_string.c | 6
lib/iso2022_map.c | 9
lib/mailer/mailer.c | 20 !
lib/mailer/outheaders.c | 8
lib/mbox/common_local.c | 43 !!!
lib/mbox/localmbx.c | 13 !
lib/mbox/mbox.c | 22 !
lib/mbox/pop.c | 20 !
lib/mbox/remote_mbx.c | 9
lib/mbox/remote_server.c | 34 !!!
lib/mbox/savefolder.c | 63 !!!!!
lib/misc/mime_types.c | 8
lib/misc/mlist.c | 8
lib/rc_handle.c | 463 +++++++++++++++++++++++!!!!!!!!!!!!!!!!!!
lib/read_rc.c | 309 +++++++++++++!!!!!!!!!!!!!
lib/remote_mbx.c | 8
lib/sb_file.c | 7
lib/syscall.c | 31 ++
lib/write_rc.c | 9
melib/mime_decode.c | 9
melib/mime_param.c | 6
melib/mimewalk.c | 6
melib/pgp_decode.c | 55 !!!!
melib/state_decode.c | 12 !
nls/C/C/C/s_aliases.m | 4
nls/C/C/C/s_elm.m | 16 !
nls/C/C/C/s_me.m | 10
nls/gencat/Makefile.SH | 10
nls/gencat/genlib.c | 26 -
shared_libs/smtp/smtp.c | 9
shared_libs/tls/tls.c | 59 !!!!!
src/a_edit.c | 8
src/a_screen.c | 9
src/alias_itemized.c | 10
src/aliases/aliases.c | 10
src/aliases/aliases_map.c | 6
src/aliases/buffer.c | 6
src/aliases/record.c | 6
src/args.c | 14 !
src/attach_menu.c | 100 +!!!!!!!
src/block/block.c | 6
src/block/fileblock.c | 8
src/block/stringblock.c | 6
src/browser.c | 26 !!
src/calendar.c | 7
src/command/command.c | 8
src/digest.c | 6
src/duplicate_removal.c | 6
src/edit.c | 94 ++!!!!!!
src/editmsg.c | 190 +++!!!!!!!!!!!!!
src/fbrowser.c | 6
src/hdrconfg.c | 24 !!
src/init.c | 8
src/list/info.c | 8
src/list/list.c | 6
src/list/reply.c | 14 !
src/mailmsg1.c | 17 !
src/mailmsg2.c | 57 !!!!!
src/messages/canceled_mail.c | 13 !
src/messages/digest.c | 6
src/messages/duplicate.c | 6
src/messages/messages.c | 6
src/messages/partial.c | 15 !
src/messages/storage.c | 6
src/messages/thread.c | 6
src/messages/thread_messages.c | 6
src/metapager.c | 52 !!!!
src/mime.c | 13 !
src/opt_generic.c | 8
src/partial.c | 6
src/pgp.c | 62 !!!!!
src/read_rc.c | 7
src/remail.c | 8
src/savecopy.c | 34 !!!
src/screen/context.c | 8
src/screen/header.c | 6
src/screen/knode.c | 6
src/screen/subpage.c | 6
src/showmsg.c | 13 !
src/syscall.c | 44 !!!
src/url/http.c | 6
src/url/imap.c | 6
src/url/mailto.c | 8
src/url/no_url.c | 6
src/url/url.c | 8
src/url/url_element.c | 6
src/url/url_path.c | 8
src/utils.c | 10
src/view_one_thread.c | 6
utils/elmalias.c | 6
utils/fastmail.c | 6
utils/from.c | 9
utils/newmail.c | 8
utils/readmsg/folder.c | 8
utils/readmsg/fstate.c | 6
utils/readmsg/readmsg.c | 9
utils/readmsg/wrapper.c | 6
121 files changed, 826 insertions(+), 28 deletions(-), 2099 modifications(!)
/ Kari Hurtta