}

}

}

> Hi,

> I am trying to insert a pattern of letters into a phrase.  For example
> the phrase is dog, cat, bird, tree.  I want to have:
> dog, cat, a, a, bird, tree
> dog, cat, a, b, bird, tree
> dog, cat, a, c, bird, tree
> dog, cat, a, d, bird, tree
> ...
> dog, cat, d, c, bird, tree
> dog, cat, d, d, bird, tree

> What I have now prints:
> dog, cat, a, a, bird, tree
> dog, cat, b, b, bird, tree
> dog, cat, c, c, bird, tree
> dog, cat, d, d, bird, tree

> I have run splint on the code and it comes back clean so there are no
> obvious mistakes.  What have I done wrong?
> Thanks,

> #include<stdio.h>
> #include<stdlib.h>
> #include<string.h>

> #define NUM_OF(x) (sizeof (x) / sizeof x[0])
> static size_t holdarea[64];

> static int done(char *words[], char *letters, char *pattern) {
> size_t i;

>    for (i=0; i<  NUM_OF(*words); i++) {

>      if ((strncmp(&pattern[i],"!",1) == 0)&&  (holdarea[i]<
> (strlen(letters)-1))) {

>        return 0;
>      }
>    }
>    return 1;
> }

> static void changeup(char *words[], char *letters, char *pattern) {
> size_t i;
> size_t k;
> size_t letlen=0;

>    if (letters != NULL) {
>      letlen = strlen(letters)-1;

>      if (pattern!=NULL) {
>        for (k=0,i=0; i<strlen(pattern); i++) {
>          switch (pattern[i]) {
>            case '!':
>              if (holdarea[i]<  letlen) {
>                printf("%c",letters[holdarea[i]++]);
>              }
>              else {
>                printf("%c",letters[holdarea[i]]);
>                holdarea[i]=0;
>              }
>              break;
>            default:
>              printf("%s",words[k]);
>              k++;
>          }
>        }
>      }
>    }
> }

> int main() {
> char *words[]={"Dog","Cat","Bird","Tree"};
> char *letters="abcd";
> char *pattern="aa!!aa";

>    while (done(words,letters,pattern)==0) {
>      changeup(words,letters,pattern);
>      printf("\n");
>    }

>    changeup(words,letters,pattern); //to get last phrase
>    printf("\n");
>    return 0;
> }

> On 7/3/2010 5:09 PM, Rich wrote:

> > Hi,

> > I am trying to insert a pattern of letters into a phrase.  For example
> > the phrase is dog, cat, bird, tree.  I want to have:
> > dog, cat, a, a, bird, tree
> > dog, cat, a, b, bird, tree
> > dog, cat, a, c, bird, tree
> > dog, cat, a, d, bird, tree
> > ...
> > dog, cat, d, c, bird, tree
> > dog, cat, d, d, bird, tree

> > What I have now prints:
> > dog, cat, a, a, bird, tree
> > dog, cat, b, b, bird, tree
> > dog, cat, c, c, bird, tree
> > dog, cat, d, d, bird, tree

> > I have run splint on the code and it comes back clean so there are no
> > obvious mistakes.  What have I done wrong?
> > Thanks,

> > #include<stdio.h>
> > #include<stdlib.h>
> > #include<string.h>

> > #define NUM_OF(x) (sizeof (x) / sizeof x[0])
> > static size_t holdarea[64];

> > static int done(char *words[], char *letters, char *pattern) {
> > size_t i;

> >    for (i=0; i<  NUM_OF(*words); i++) {

>      NUM_OF doesn't do what you want here.  See question 6.21 on
> the comp.lang.c Frequently Asked Questions (FAQ) web page at
> <http://www.c-faq.com/>.

> >      if ((strncmp(&pattern[i],"!",1) == 0)&&  (holdarea[i]<
> > (strlen(letters)-1))) {

>      I can't figure out what you're trying to accomplish -- it just
> makes no sense to me.  What's the relationship between `i' (whose
> upper limit is derived from `words', sort of) and `pattern'?  Why
> do you think the length of `pattern' depends on some attribute of
> `words'?

>      I haven't spent the time to examine your code in detail,
> because it's a warm summer afternoon at the start of a holiday
> weekend and my brain feels too lazy to try to figure out what
> you think these functions are supposed to do.  

>done is what tells me I have generated all of the phrases.  changeup
>is supposed to change the letters, i.e. a a should become a b, then a
>c, then a d, etc.  holdarea is an array of int that stores this
>information. When holdarea is 00 it prints aa, when it is 01 it prints
>ab, 02 is ac, etc.

> What have I done wrong?

Denis McMahon wrote:
> On 03/07/10 22:09, Rich wrote:

>> What have I done wrong?

> Try the following little proglet:

> /* proglet starts */

> #include <stdio.h>

> int main() {
>   int i, j;
>   for (i = 0; i < 4; i++)
>     for (j = 0; j < 4; j++)
>       printf("some words %c %c more words\n",'a' + i, 'a' + j);

> I can't be bothered to solve the original problem so I'm going
> to make snide remarks about other people's input instead!

> On Sat, 3 Jul 2010 14:39:50 -0700 (PDT), Rich <rtillm...@gmail.com>
> wrote:

> >done is what tells me I have generated all of the phrases.  changeup
> >is supposed to change the letters, i.e. a a should become a b, then a
> >c, then a d, etc.  holdarea is an array of int that stores this
> >information. When holdarea is 00 it prints aa, when it is 01 it prints
> >ab, 02 is ac, etc.

> Your problem is in the changeup function.
> This expression is incrementing the wrong element of holdarea[]

>         printf("%c",letters[holdarea[i]++]);