Nice Chromium and clumsy memset

[Andrey Karpov]

We would like to suggest reading the series of articles dedicated to the recommendations on writing code of high quality using the examples of errors found in the Chromium project. This is the first part which will be devoted to the memset function.

Gentlemen, we must do something about the memset function in C++ programs! Rather, it is clear what we must do at once - we have to stop using it. I wrote the article "The most dangerous function in the C/C++ world" at the time. I think it is easy to guess that this article will be exactly about memset.

Continue: https://www.viva64.com/en/b/0553/

[Öö Tiib]

On Friday, 26 January 2018 10:36:11 UTC+2, Andrey Karpov wrote:
> We would like to suggest reading the series of articles dedicated to the recommendations on writing code of high quality using the examples of errors found in the Chromium project. This is the first part which will be devoted to the memset function.

High quality recommendation suggests to use *something*.

For example either std::array<WebUChar,kTextLengthCap> or
std::basic_string<WebUChar> instead of those raw fixed or
allocated with new arrays in C++ ... and decades old idioms
'memset(p, 0, length * sizeof *p);' in C.

But your article fails even to tell relation between
constant 'kTextLengthCap' and variable 'text_length_cap'
as in

WebUChar text[kTextLengthCap];

and

memset(key_event->text, 0, text_length_cap);

"High quality" indeed. :D

[cda...@gmail.com]

Mr. Rick's CAlive fixes such things.