Private Messages

1 view
Skip to first unread message

eksatx

unread,
Jun 24, 2009, 5:23:45 PM6/24/09
to CommunityEngine
I am in the process of fleshing out this functionality as it is so
close to being done already.

Here is what I have done so far:

1. Add "You have mail" widget to the header for users that have unread
messages.
2. Add link to Inbox to pull-down menu
3. Add link to "Send me a message" to user profile pages
4. Add link to Inbox to user dashboard page

Here is what I have yet to do:

1. Add ability to send a message to multiple recipients.
2. Write tests (I think I just need to write some functional tests as
the plugin appears to include some unit tests).

Before I go too much further, a few questions:

1. Has somebody already done this (don't want to duplicate work)?
2. Does anybody have any questions / suggestions about what I listed
above?
3. Are there any suggestions for additional functionality?

Levi Rosol

unread,
Jun 25, 2009, 9:06:37 AM6/25/09
to communi...@googlegroups.com
sounds like some pretty sweet functionality. I know i'll put it to use in my app.

Are you using an existing gem for this or are you building it from scratch?

--
Levi Rosol
Twitter: @LeviRosol

eksatx

unread,
Jun 27, 2009, 7:51:36 PM6/27/09
to CommunityEngine
This uses a plugin called simple_private_messages. Here is the url
where it is maintained:

http://github.com/professionalnerd/simple-private-messages

I have completed the TODOs I referenced in my previous message.

The plugin only supports messages with single recipients, so I added
the multi-recipient support by adding logic to the controller. The
"right" way to do it (IMHO) would be to patch the plugin to support
multiple recipients in the model, but doing it in the controller was
fast 'n' easy and it works quite well so I think it is ok.

I wrote functional tests because the plugin comes with unit tests. I
need some help here as I am unfamiliar with how to run tests in a
plugin that is embedded inside the community_engine plugin.

Do those tests get run automatically when I run the community_engine
tests? What do I have to do?

Once I know the answer I can commit my changes and send a pull request
to Bruno.

Help!

On Jun 25, 8:06 am, Levi Rosol <levi.ro...@gmail.com> wrote:
> sounds like some pretty sweet functionality. I know i'll put it to use in my
> app.
>
> Are you using an existing gem for this or are you building it from scratch?
>
> --
> Levi Rosol
> Twitter: @LeviRosol
>

eksatx

unread,
Jun 27, 2009, 8:59:08 PM6/27/09
to CommunityEngine
I think I answered my own question -- I just noticed that there are
some unit tests for the Message model in the community_engine unit
tests directory (maybe the generator that came with the plugin created
these?). In any case these get run along with the other
community_engine tests.

I'll commit this stuff and send a pull request soon.

Levi Rosol

unread,
Jun 27, 2009, 9:06:01 PM6/27/09
to communi...@googlegroups.com
right on. Hope to see this in the edge branch soon.

good work on getting this done.

--
Levi Rosol
Twitter: @LeviRosol



eksatx

unread,
Jun 30, 2009, 7:09:31 PM6/30/09
to CommunityEngine
This is in edge now. Enjoy!

On Jun 27, 8:06 pm, Levi Rosol <levi.ro...@gmail.com> wrote:
> right on. Hope to see this in the edge branch soon.
>
> good work on getting this done.
>
> --
> Levi Rosol
> Twitter: @LeviRosol
>
Reply all
Reply to author
Forward
0 new messages