Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Cometd 2.4.0 Javascript AMD compliant patch
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
neek  
View profile  
 More options Mar 20 2012, 3:22 am
From: neek <neekfenw...@gmail.com>
Date: Tue, 20 Mar 2012 00:22:27 -0700 (PDT)
Local: Tues, Mar 20 2012 3:22 am
Subject: Re: Cometd 2.4.0 Javascript AMD compliant patch

On Feb 28, 4:44 pm, sarurobi <vittorio.balles...@gmail.com> wrote:

> Sorry, that's the best I could do as I don't have a Jira account
> neither I was able to "attach" something (BTW: how the hell it is
> supposed to work with google groups ?? )

Yeah, last time I looked you could attach a file to a pool of files on
the group itself, but not to individual posts or 'Discussions'.  Seems
crazy.

> Here's a link to my dropbox public folder:http://dl.dropbox.com/u/11489985/p

Thank you very much.  Your patch seems to be backwards but I can see
what you were doing.  I've patched up cometd.js files, and also
reload.js and ReloadExtension.js since I use that.  Other extensions
would need patching accordingly.

However, my ready() events then fail to work, which seems to be a dojo
loader bug.

I'm not sure your code is correct.  Where you have e.g.:

    define("org/cometd",[],function() {

at the top of org/cometd.js, I'm used to syntax like this:

    define( [ "dojo/_base/declare", .. list of dependencies .. ],
function(declare, .. other deps ..) {
        return declare("org.cometd", null, { .. body here .. })
    })

Something alone those lines, anyway.  I've tried updating the code to
match this syntax, but I got lost converting the cometd objects to a
format that's compatible with "return declare", and I have a feeling
this is a wasted effort anyway since Simone said he was working toward
an official AMD patch (though I've seen no word for almost a month on
that).

Due to the loader bug and ready() event not working, this simple AMD
conversion is a non-starter for me.  I'm going to have to leave
async:false in the data-dojo-config, and hope the cometd project comes
through with an AMD compliant version before too long.

Nick


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.