should dependencies be autowired from parent factory?

[Chris Blackwell]

I have a framework one app that has a parent beanfactory and one for each subsystem.

I was toying with the idea of using aop with annotations to do action based authorization on the controller methods.

So in my beanfactory for the  "home" subsystem i have

<bean id="AuthInterceptor" class="model.security.aop.AuthorizationInterceptor" /> 

<aop:config>

<aop:aspect ref="AuthInterceptor">

<aop:around method="authorize" pointcut="@annotation(authorize)" /> 

</aop:aspect>

</aop:config>

<bean id="TestController" class="modules.home.controllers.test" />

The problem is AuthInterceptor relies on some beans in the parent factory, like the SecurityService and these don't get wired in.

Is this a bug, or just tha way it is ?

Chris

[Mark Mandel]

In theory - it should work, looking at the code:

https://github.com/markmandel/coldspring/blob/develop/coldspring/beans/BeanDefinitionRegistry.cfc#L115

Mark

--
You received this message because you are subscribed to the Google Groups "ColdSpring-Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to coldspring-use...@googlegroups.com.
To post to this group, send email to coldspri...@googlegroups.com.
Visit this group at http://groups.google.com/group/coldspring-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
E: mark....@gmail.com
T: http://www.twitter.com/neurotic
W: www.compoundtheory.com

2 Devs from Down Under Podcast

http://www.2ddu.com/

[Chris Blackwell]

Hi Mark,

Well, that's what i thought.. but its not what i see

My CustomerController  bean is marked a BeanFactoryAware, and the Home beanfactory is correctly injected into it, so i know its getting loaded from the beanfactory and not by fw/1 manually instantiating it.  I've also double checked this by setting a property on it via the bean def.  

But if i execute this in my controller

dump(var=variables.beanFactory.containsbean("CustomerService"), label="contains bean CustomerService?");

dump(var=variables.beanFactory.hasParentBeanFactory(), label="has parent bean factory?");

dump(var=variables.beanFactory.getParentBeanFactory().containsbean("CustomerService"), label="parent contains bean CustomerService?");

abort;

I get 

contains bean CustomerService?

boolean false

has parent bean factory?

boolean true

parent contains bean CustomerService?

boolean true

The problem is that when the child bean factory is created there is no parent set, so the BeanDefinistionRegistry is init'd with no reference to the parent.  This means that you can never get inside this if block.

A work around seems to be to call refresh() after setParentBeanFactory(), but its not obvious that you need to do that, so maybe this should be done for you inside setParentBeanFactory() ?

Chris

[Mark Mandel]

Ah.

I take it you are passing in the config locations through the init constructor?

You should really be using the advanced instantiation approach to set the parent before the .refresh() call.

http://sourceforge.net/apps/trac/coldspring/wiki/CreatingABeanFactory#AdvancedInstantiation

Let me know if that works.

Mark

[Chris Blackwell]

Yep, that fixes the problem.

Is this behaviour documented? If not, I think a note in the setParentBeanFactory docs and method hint would be a help.

I'll throw something together and submit it one way or t'other

Chris

[Mark Mandel]

Yeah - it probably should be added to the advanced configuration section:

http://sourceforge.net/apps/trac/coldspring/wiki/CreatingABeanFactory#AdvancedInstantiation

Mark